Skip to content

Commit 6e1be45

Browse files
mazhalaiOlga Kopylova
authored andcommitted
MAGETWO-44736: Contribute Ogres Bugfixes
- adding reset to so that behavior is consistent with isAvailable which reloads data. - fix specifcally for sample data installation build
1 parent f19f973 commit 6e1be45

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

lib/internal/Magento/Framework/Module/ModuleList.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ public function isModuleInfoAvailable()
139139
*/
140140
private function loadConfigData()
141141
{
142+
$this->config->resetData();
142143
if (null === $this->configData && null !== $this->config->get(ConfigOptionsListConstants::KEY_MODULES)) {
143144
$this->configData = $this->config->get(ConfigOptionsListConstants::KEY_MODULES);
144145
}

lib/internal/Magento/Framework/Module/Test/Unit/ModuleListTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ protected function setUp()
4747

4848
public function testGetAll()
4949
{
50+
$this->config->expects($this->exactly(2))->method('resetData');
5051
$this->setLoadAllExpectation();
5152
$this->setLoadConfigExpectation();
5253
$expected = ['foo' => self::$allFixture['foo']];
@@ -64,6 +65,7 @@ public function testGetAllNoData()
6465

6566
public function testGetOne()
6667
{
68+
$this->config->expects($this->exactly(2))->method('resetData');
6769
$this->setLoadAllExpectation();
6870
$this->setLoadConfigExpectation();
6971
$this->assertSame(['key' => 'value'], $this->model->getOne('foo'));
@@ -72,6 +74,7 @@ public function testGetOne()
7274

7375
public function testGetNames()
7476
{
77+
$this->config->expects($this->exactly(2))->method('resetData');
7578
$this->setLoadAllExpectation(false);
7679
$this->setLoadConfigExpectation();
7780
$this->assertSame(['foo'], $this->model->getNames());
@@ -80,6 +83,7 @@ public function testGetNames()
8083

8184
public function testHas()
8285
{
86+
$this->config->expects($this->exactly(2))->method('resetData');
8387
$this->setLoadAllExpectation(false);
8488
$this->setLoadConfigExpectation();
8589
$this->assertTrue($this->model->has('foo'));
@@ -88,6 +92,7 @@ public function testHas()
8892

8993
public function testIsModuleInfoAvailable()
9094
{
95+
$this->config->expects($this->once())->method('resetData');
9196
$this->setLoadConfigExpectation(true);
9297
$this->assertTrue($this->model->isModuleInfoAvailable());
9398
}

0 commit comments

Comments
 (0)