ENGCOM-5538: No validation "Sort Order" in "New Rating" form issue 23984 #23985

Author: VladimirZaets

app/code/Magento/Review/Block/Adminhtml/Rating/Edit/Tab/Form.php

@@ -3,8 +3,13 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types = 1);
+
 namespace Magento\Review\Block\Adminhtml\Rating\Edit\Tab;
 
+/**
+ * Class Magento\Review\Block\Adminhtml\Rating\Edit\Tab\Form
+ */
 class Form extends \Magento\Backend\Block\Widget\Form\Generic
 {
     /**
@@ -227,7 +232,15 @@ protected function addVisibilityFieldset()
             ['label' => __('Is Active'), 'name' => 'is_active', 'value' => 1]
         );
         $this->getFieldset('visibility_form')
-            ->addField('position', 'text', ['label' => __('Sort Order'), 'name' => 'position']);
+            ->addField(
+                'position',
+                'text',
+                [
+                    'label' => __('Sort Order'),
+                    'name' => 'position',
+                    'class' => 'validate-not-negative-number'
+                ]
+            );
     }
 
     /**
@@ -242,8 +255,6 @@ protected function initFieldset($formId, array $config)
         if (!isset($this->fieldset[$formId])) {
             if (!$this->getForm()->getElement($formId)) {
                 $this->fieldset[$formId] = $this->getForm()->addFieldset($formId, $config);
-            } elseif ($this->getForm()->getElement($formId)) {
-                //do nothing
             }
         }
     }