#27499: Filtering data for insert

Author: sivaschenko

app/code/Magento/MediaGallery/Model/Asset/Command/Save.php

@@ -7,11 +7,11 @@
 
 namespace Magento\MediaGallery\Model\Asset\Command;
 
-use Magento\MediaGalleryApi\Api\Data\AssetInterface;
-use Magento\MediaGalleryApi\Model\Asset\Command\SaveInterface;
 use Magento\Framework\App\ResourceConnection;
 use Magento\Framework\Exception\CouldNotSaveException;
 use Magento\Framework\Reflection\DataObjectProcessor;
+use Magento\MediaGalleryApi\Api\Data\AssetInterface;
+use Magento\MediaGalleryApi\Model\Asset\Command\SaveInterface;
 use Psr\Log\LoggerInterface;
 
 /**
@@ -72,7 +72,7 @@ public function execute(AssetInterface $mediaAsset): int
 
             $connection->insertOnDuplicate(
                 $tableName,
-                array_filter($this->objectProcessor->buildOutputDataArray($mediaAsset, AssetInterface::class))
+                $this->filterData($this->objectProcessor->buildOutputDataArray($mediaAsset, AssetInterface::class))
             );
             return (int) $connection->lastInsertId($tableName);
         } catch (\Exception $exception) {
@@ -81,4 +81,28 @@ public function execute(AssetInterface $mediaAsset): int
             throw new CouldNotSaveException($message, $exception);
         }
     }
+
+    /**
+     * Filter data to get flat array without null values
+     *
+     * @param array $data
+     * @return array
+     */
+    private function filterData(array $data): array
+    {
+        $filteredData = [];
+        foreach ($data as $key => $value) {
+            if ($value === null) {
+                continue;
+            }
+            if (is_array($value)) {
+                continue;
+            }
+            if (is_object($value)) {
+                continue;
+            }
+            $filteredData[$key] = $value;
+        }
+        return $filteredData;
+    }
 }

app/code/Magento/MediaGallery/Model/ResourceModel/SaveAssets.php

@@ -66,7 +66,7 @@ public function execute(array $assets): void
             try {
                 $connection->insertOnDuplicate(
                     $tableName,
-                    array_filter($this->objectProcessor->buildOutputDataArray($asset, AssetInterface::class))
+                    $this->filterData($this->objectProcessor->buildOutputDataArray($asset, AssetInterface::class))
                 );
             } catch (\Exception $exception) {
                 $this->logger->critical($exception);
@@ -85,4 +85,28 @@ public function execute(array $assets): void
             );
         }
     }
+
+    /**
+     * Filter data to get flat array without null values
+     *
+     * @param array $data
+     * @return array
+     */
+    private function filterData(array $data): array
+    {
+        $filteredData = [];
+        foreach ($data as $key => $value) {
+            if ($value === null) {
+                continue;
+            }
+            if (is_array($value)) {
+                continue;
+            }
+            if (is_object($value)) {
+                continue;
+            }
+            $filteredData[$key] = $value;
+        }
+        return $filteredData;
+    }
 }