MAGETWO-44552: [Github] Installer Readiness Check does not check file permissions recursively

- added recursive check.

Author: mazhalai

setup/src/Magento/Setup/Model/FilePermissions.php

@@ -109,14 +109,35 @@ public function getInstallationCurrentWritableDirectories()
     {
         if (!$this->installationCurrentWritableDirectories) {
             foreach ($this->installationWritableDirectories as $code => $path) {
-                if ($this->isWritable($code)) {
+                if ($this->isWritable($code) && $this->checkRecursiveDirectories($path)) {
                     $this->installationCurrentWritableDirectories[] = $path;
                 }
             }
         }
         return $this->installationCurrentWritableDirectories;
     }
 
+    /**
+     * Check all sub-directories
+     *
+     * @param string $directory
+     * @return bool
+     */
+    private function checkRecursiveDirectories($directory)
+    {
+        $flag = true;
+        $directoryIterator = new \RecursiveIteratorIterator(
+            new \RecursiveDirectoryIterator($directory),
+            \RecursiveIteratorIterator::LEAVES_ONLY | \RecursiveIteratorIterator::CATCH_GET_CHILD
+        );
+        foreach($directoryIterator as $subDirectory) {
+            if ($subDirectory->isDir() && !$subDirectory->isWritable()) {
+                $flag = false;
+            }
+        }
+        return $flag;
+    }
+
     /**
      * Retrieve list of currently non-writable directories for application
      *

setup/view/magento/setup/readiness-check/progress.phtml

@@ -446,7 +446,9 @@
                         </a>
                     </p>
                     <p>
-                        The best way to resolve this is to allow write permissions for the following Magento directories. The exact fix depends on your server, your host, and other system variables.
+                        The best way to resolve this is to allow write permissions for the following Magento
+                        directories and their sub-directories. The exact fix depends on your server, your host,
+                        and other system variables.
                         <br>
                         Our <a href="http://devdocs.magento.com/guides/v2.0/install-gde/trouble/cman/tshoot_install_perms.html" target="_blank">File Permission Help</a> can get you started.
                     </p>