AC-9755:Set default collation to utf8mb4 for MySQL

Author: glo17680

lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/MySQL/DbSchemaWriter.php

@@ -80,6 +80,8 @@ class DbSchemaWriter implements DbSchemaWriterInterface
      */
     private $columnConfig;
 
+    private const COLUMN_TYPE = ['varchar', 'char', 'text', 'mediumtext', 'longtext'];
+
     /***
      * @param ResourceConnection $resourceConnection
      * @param StatementFactory $statementFactory
@@ -106,6 +108,15 @@ public function __construct(
      */
     public function createTable($tableName, $resource, array $definition, array $options)
     {
+        if (count($definition)) {
+            foreach ($definition as $index => $value) {
+                if ($this->isColumnExists($value, self::COLUMN_TYPE)) {
+                    if (str_contains($index, 'column')) {
+                        $definition[$index] = $this->applyCharsetAndCollation($value);
+                    }
+                }
+            }
+        }
         $sql = sprintf(
             "(\n%s\n) ENGINE=%s DEFAULT CHARSET=%s DEFAULT COLLATE=%s %s",
             implode(", \n", $definition),
@@ -226,13 +237,10 @@ public function modifyTableOption($tableName, $resource, $optionName, $optionVal
      */
     public function modifyColumn($columnName, $resource, $tableName, $columnDefinition)
     {
-        $columnTypes = ['varchar', 'char', 'text'];
-        foreach ($columnTypes as $type) {
-            if (str_contains($columnDefinition, $type)) {
-                $columnDefinition = $this->applyCharsetAndCollation($columnDefinition);
-                break;
-            }
+        if ($this->isColumnExists($columnDefinition, self::COLUMN_TYPE)) {
+            $columnDefinition = $this->applyCharsetAndCollation($columnDefinition);
         }
+
         $sql = sprintf(
             'MODIFY COLUMN %s',
             $columnDefinition
@@ -404,4 +412,20 @@ private function applyCharsetAndCollation(string $columnDefinition): string
             return implode(" ", $columnsAttribute);
         }
     }
+
+    /***
+     * Checks if any column of type varchar,char or text (mediumtext/longtext)
+     *
+     * @param string $definition
+     * @param array $columntypes
+     * @return bool
+     */
+    private function isColumnExists(string $definition, array $columntypes): bool
+    {
+        if (!empty($definition)) {
+            $type = explode(' ', $definition);
+            $pattern = '/\b(' . implode('|', array_map('preg_quote', $columntypes)) . ')\b/i';
+            return preg_match($pattern, $type[1]) === 1;
+        }
+    }
 }