MAGETWO-34991: Eliminate exceptions from the list Part2

Author: Yurii Torbyk

app/code/Magento/Backend/Controller/Adminhtml/System/Design/Delete.php

@@ -20,7 +20,7 @@ public function execute()
             try {
                 $design->delete();
                 $this->messageManager->addSuccess(__('You deleted the design change.'));
-            } catch (\Magento\Framework\Exception $e) {
+            } catch (\Magento\Framework\Exception\LocalizedException $e) {
                 $this->messageManager->addError($e->getMessage());
             } catch (\Exception $e) {
                 $this->messageManager->addException($e, __("Cannot delete the design change."));

app/code/Magento/Backend/Model/Menu/Config/Menu/Dom.php

@@ -15,7 +15,8 @@ class Dom extends \Magento\Framework\Config\Dom
      *
      * @param string $nodePath
      * @return \DOMElement|null
-     * @throws \Magento\Framework\Exception an exception is possible if original document contains multiple fixed nodes
+     * @throws \Magento\Framework\Exception\LocalizedException an exception is possible if original document contains
+     * multiple fixed nodes
      */
     protected function _getMatchedNode($nodePath)
     {

app/code/Magento/Backend/Test/Unit/Model/Menu/ItemTest.php

@@ -208,7 +208,7 @@ public function testIsAllowedReturnsFalseIfResourceIsNotAvailable()
         )->with(
             'Magento_Config::config'
         )->will(
-            $this->throwException(new \Magento\Framework\Exception())
+            $this->throwException(new \Magento\Framework\Exception\LocalizedException(__('Error')))
         );
         $this->assertFalse($this->_model->isAllowed());
     }

app/code/Magento/Backup/Controller/Adminhtml/Index/Rollback.php

@@ -44,7 +44,7 @@ public function execute()
             }
 
             if (!$backup->getTime()) {
-                throw new \Magento\Framework\Backup\Exception\CantLoadSnapshot();
+                throw new \Magento\Framework\Backup\Exception\CantLoadSnapshot(__('Can\'t load snapshot archive'));
             }
 
             $type = $backup->getType();

app/code/Magento/Catalog/Controller/Adminhtml/Product/MassStatus.php

@@ -74,8 +74,6 @@ public function execute()
                 ->updateAttributes($productIds, ['status' => $status], $storeId);
             $this->messageManager->addSuccess(__('A total of %1 record(s) have been updated.', count($productIds)));
             $this->_productPriceIndexerProcessor->reindexList($productIds);
-        } catch (\Magento\Framework\Exception $e) {
-            $this->messageManager->addError($e->getMessage());
         } catch (\Magento\Framework\Exception\LocalizedException $e) {
             $this->messageManager->addError($e->getMessage());
         } catch (\Exception $e) {

app/code/Magento/Catalog/Model/Indexer/Product/Flat/Action/Full.php

@@ -17,7 +17,7 @@ class Full extends \Magento\Catalog\Model\Indexer\Product\Flat\AbstractAction
      * @param null|array $ids
      *
      * @return \Magento\Catalog\Model\Indexer\Product\Flat\Action\Full
-     * @throws \Magento\Framework\Exception
+     * @throws \Magento\Framework\Exception\LocalizedException
      * @throws \Exception
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */

app/code/Magento/Cms/Block/Page.php

@@ -118,7 +118,7 @@ protected function _prepareLayout()
      * Prepare breadcrumbs
      *
      * @param \Magento\Cms\Model\Page $page
-     * @throws \Magento\Framework\Exception
+     * @throws \Magento\Framework\Exception\LocalizedException
      * @return void
      */
     protected function _addBreadcrumbs(\Magento\Cms\Model\Page $page)

app/code/Magento/Customer/Test/Unit/Block/Address/EditTest.php

@@ -166,7 +166,7 @@ public function testSetLayoutWithOwnAddressAndPostedData()
     }
 
     /**
-     * @throws \Magento\Framework\Exception
+     * @throws \Magento\Framework\Exception\LocalizedException
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function testSetLayoutWithAlienAddress()

app/code/Magento/Customer/Test/Unit/Model/Resource/Group/Grid/ServiceCollectionTest.php

@@ -217,7 +217,7 @@ public function testGetSearchCriteriaAnd()
      * @param string[] $fields
      * @param array $conditions
      *
-     * @expectedException \Magento\Framework\Exception
+     * @expectedException \Magento\Framework\Exception\LocalizedException
      * @expectedExceptionMessage When passing in a field array there must be a matching condition array
      * @dataProvider addFieldToFilterInconsistentArraysDataProvider
      */

app/code/Magento/DesignEditor/Block/Adminhtml/Editor/Tools/Code/ImageSizing.php

@@ -89,7 +89,7 @@ protected function _prepareForm()
                 \Magento\DesignEditor\Model\Editor\Tools\Controls\Factory::TYPE_IMAGE_SIZING,
                 $this->_themeContext->getStagingTheme()
             );
-        } catch (\Magento\Framework\Exception $e) {
+        } catch (\Magento\Framework\Exception\LocalizedException $e) {
             $isFilePresent = false;
         }