MAGETWO-34920: Catch all exceptions inside of Phrase::__toString() method and log messages

Yuri Kovsher · Yuri Kovsher · commit 6d28617c4cec · 2015-04-22T15:53:39.000+03:00
diff --git a/lib/internal/Magento/Framework/Phrase/Renderer/Inline.php b/lib/internal/Magento/Framework/Phrase/Renderer/Inline.php
@@ -51,6 +51,7 @@ public function __construct(
      * @param [] $arguments
      * @return string
      * @throws \Exception
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function render(array $source, array $arguments)
     {
diff --git a/lib/internal/Magento/Framework/Phrase/Renderer/Translate.php b/lib/internal/Magento/Framework/Phrase/Renderer/Translate.php
@@ -44,6 +44,7 @@ public function __construct(
      * @param [] $arguments
      * @return string
      * @throws \Exception
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function render(array $source, array $arguments)
     {

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,7 @@ public function __construct(`
`51`	`51`	`* @param [] $arguments`
`52`	`52`	`* @return string`
`53`	`53`	`* @throws \Exception`
	`54`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`54`	`55`	`*/`
`55`	`56`	`public function render(array $source, array $arguments)`
`56`	`57`	`{`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ public function __construct(`
`44`	`44`	`* @param [] $arguments`
`45`	`45`	`* @return string`
`46`	`46`	`* @throws \Exception`
	`47`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`47`	`48`	`*/`
`48`	`49`	`public function render(array $source, array $arguments)`
`49`	`50`	`{`