BUG#AC-2052: TypeError when loading UPS shipping rates if no allowed shipping methods selected - issue fixed

glo80326 · glo80326 · commit 6cef041826af · 2021-12-30T23:33:11.000+05:30
diff --git a/app/code/Magento/Ups/Model/Carrier.php b/app/code/Magento/Ups/Model/Carrier.php
@@ -1350,10 +1350,8 @@ public function getResponse()
                 }
             }
         }
-        if (!$statuses) {
-            $statuses = __('Empty response');
-        }
-        return $statuses;
+
+        return $statuses ?: __('Empty response');
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -1350,10 +1350,8 @@ public function getResponse()`
`1350`	`1350`	`}`
`1351`	`1351`	`}`
`1352`	`1352`	`}`
`1353`		`- if (!$statuses) {`
`1354`		`- $statuses = __('Empty response');`
`1355`		`- }`
`1356`		`- return $statuses;`
	`1353`	`+`
	`1354`	`+ return $statuses ?: __('Empty response');`
`1357`	`1355`	`}`
`1358`	`1356`
`1359`	`1357`	`/**`