Skip to content

Commit 6c7f304

Browse files
committed
ENGCOM-7479: Return inheritance to migrated controllers
1 parent 643ef19 commit 6c7f304

File tree

2 files changed

+8
-9
lines changed
  • app/code/Magento

2 files changed

+8
-9
lines changed

app/code/Magento/LoginAsCustomerUi/Controller/Login/Index.php

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77

88
namespace Magento\LoginAsCustomerUi\Controller\Login;
99

10-
use Magento\Framework\App\Action\Action;
11-
use Magento\Framework\App\Action\Context;
1210
use Magento\Customer\Api\CustomerRepositoryInterface;
1311
use Magento\Framework\App\RequestInterface;
1412
use Magento\Framework\Controller\Result\Redirect;
@@ -25,12 +23,12 @@
2523
/**
2624
* Login As Customer storefront login action
2725
*/
28-
class Index extends Action implements HttpGetActionInterface
26+
class Index implements HttpGetActionInterface
2927
{
3028
/**
3129
* @var ResultFactory
3230
*/
33-
protected $resultFactory;
31+
private $resultFactory;
3432

3533
/**
3634
* @var RequestInterface
@@ -55,15 +53,14 @@ class Index extends Action implements HttpGetActionInterface
5553
/**
5654
* @var ManagerInterface
5755
*/
58-
protected $messageManager;
56+
private $messageManager;
5957

6058
/**
6159
* @var LoggerInterface
6260
*/
6361
private $logger;
6462

6563
/**
66-
* @param Context $context
6764
* @param ResultFactory $resultFactory
6865
* @param RequestInterface $request
6966
* @param CustomerRepositoryInterface $customerRepository
@@ -73,7 +70,6 @@ class Index extends Action implements HttpGetActionInterface
7370
* @param LoggerInterface $logger
7471
*/
7572
public function __construct(
76-
Context $context,
7773
ResultFactory $resultFactory,
7874
RequestInterface $request,
7975
CustomerRepositoryInterface $customerRepository,
@@ -82,7 +78,6 @@ public function __construct(
8278
ManagerInterface $messageManager,
8379
LoggerInterface $logger
8480
) {
85-
parent::__construct($context);
8681
$this->resultFactory = $resultFactory;
8782
$this->request = $request;
8883
$this->customerRepository = $customerRepository;

app/code/Magento/Version/Controller/Index/Index.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,11 @@ class Index extends Action implements HttpGetActionInterface
3535
* @param RawResponseFactory $rawFactory
3636
* @param ProductMetadataInterface $productMetadata
3737
*/
38-
public function __construct(Context $context, RawResponseFactory $rawFactory, ProductMetadataInterface $productMetadata)
38+
public function __construct(
39+
Context $context,
40+
RawResponseFactory $rawFactory,
41+
ProductMetadataInterface $productMetadata
42+
)
3943
{
4044
parent::__construct($context);
4145
$this->rawFactory = $rawFactory;

0 commit comments

Comments
 (0)