ACPT-1709: Clean up skip-list for GraphQlState Test

andimov · andimov · commit 6c05a8b19718 · 2023-12-14T22:16:30.000-06:00
-- fix test failures
diff --git a/app/code/Magento/Catalog/Test/Unit/Model/Product/Webapi/Rest/RequestTypeBasedDeserializerTest.php b/app/code/Magento/Catalog/Test/Unit/Model/Product/Webapi/Rest/RequestTypeBasedDeserializerTest.php
@@ -19,6 +19,11 @@
 use Magento\Framework\Xml\ParserFactory as ParserXmlFactory;
 use PHPUnit\Framework\MockObject\MockObject;
 
+/**
+ * A Test for RequestTypeBasedDeserializer
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class RequestTypeBasedDeserializerTest extends \PHPUnit\Framework\TestCase
 {
     /** @var RequestTypeBasedDeserializer */
diff --git a/app/code/Magento/ConfigurableProductGraphQl/Model/Cart/BuyRequest/SuperAttributeDataProvider.php b/app/code/Magento/ConfigurableProductGraphQl/Model/Cart/BuyRequest/SuperAttributeDataProvider.php
@@ -25,6 +25,8 @@
 
 /**
  * DataProvider for building super attribute options in buy requests
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class SuperAttributeDataProvider implements BuyRequestDataProviderInterface
 {
@@ -62,6 +64,7 @@ class SuperAttributeDataProvider implements BuyRequestDataProviderInterface
      * @param MetadataPool $metadataPool
      * @param StockStateInterface $stockState
      * @param ArrayManagerFactory|null $arrayManagerFactory
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function __construct(
         ArrayManager $arrayManager,
diff --git a/app/code/Magento/PaypalGraphQl/Model/PayflowProAdditionalDataProvider.php b/app/code/Magento/PaypalGraphQl/Model/PayflowProAdditionalDataProvider.php
@@ -18,7 +18,7 @@ class PayflowProAdditionalDataProvider implements AdditionalDataProviderInterfac
 {
     /**
      * @param ArrayManager $arrayManager
-     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      * phpcs:disable Magento2.CodeAnalysis.EmptyBlock
      */
     public function __construct(ArrayManager $arrayManager)
diff --git a/app/code/Magento/PaypalGraphQl/Model/PayflowProCcVaultAdditionalDataProvider.php b/app/code/Magento/PaypalGraphQl/Model/PayflowProCcVaultAdditionalDataProvider.php
@@ -19,7 +19,7 @@ class PayflowProCcVaultAdditionalDataProvider implements AdditionalDataProviderI
 
     /**
      * @param ArrayManager $arrayManager
-     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      * phpcs:disable Magento2.CodeAnalysis.EmptyBlock
      */
     public function __construct(ArrayManager $arrayManager)
diff --git a/app/code/Magento/PaypalGraphQl/Model/Plugin/Resolver/SetPaymentMethodOnCart.php b/app/code/Magento/PaypalGraphQl/Model/Plugin/Resolver/SetPaymentMethodOnCart.php
@@ -41,7 +41,6 @@ class SetPaymentMethodOnCart
 
     /**
      * @var ArrayManagerFactory
-     *
      * phpcs:disable Magento2.Commenting.ClassPropertyPHPDocFormatting
      */
     private readonly ArrayManagerFactory $arrayManagerFactory;
@@ -63,6 +62,7 @@ class SetPaymentMethodOnCart
      * @param ConfigProvider $configProvider
      * @param array $allowedPaymentMethodCodes
      * @param ArrayManagerFactory|null $arrayManagerFactory
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function __construct(
         CheckoutFactory $checkoutFactory,
diff --git a/app/code/Magento/QuoteGraphQl/Model/Cart/BuyRequest/CustomizableOptionsDataProvider.php b/app/code/Magento/QuoteGraphQl/Model/Cart/BuyRequest/CustomizableOptionsDataProvider.php
@@ -18,7 +18,7 @@ class CustomizableOptionsDataProvider implements BuyRequestDataProviderInterface
 {
     /**
      * @var ArrayManagerFactory
-     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      * phpcs:disable Magento2.Commenting.ClassPropertyPHPDocFormatting
      */
     private readonly ArrayManagerFactory $arrayManagerFactory;
diff --git a/app/code/Magento/QuoteGraphQl/Model/Cart/BuyRequest/QuantityDataProvider.php b/app/code/Magento/QuoteGraphQl/Model/Cart/BuyRequest/QuantityDataProvider.php
@@ -19,7 +19,7 @@ class QuantityDataProvider implements BuyRequestDataProviderInterface
 {
     /**
      * @var ArrayManagerFactory
-     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      * phpcs:disable Magento2.Commenting.ClassPropertyPHPDocFormatting
      */
     private readonly ArrayManagerFactory $arrayManagerFactory;
diff --git a/app/code/Magento/Sales/Model/ResourceModel/Attribute.php b/app/code/Magento/Sales/Model/ResourceModel/Attribute.php
@@ -88,11 +88,11 @@ protected function _beforeSaveAttribute(AbstractModel $object, $attribute)
      * Perform actions after object save
      *
      * @param AbstractModel $object
-     * @param string $attribute
+     * @param mixed $attribute
      * @return $this
      * @throws \Exception
      */
-    public function saveAttribute(AbstractModel $object, $attribute)
+    public function saveAttribute(AbstractModel $object, mixed $attribute)
     {
         if ($attribute instanceof AbstractAttribute) {
             $attributes = $attribute->getAttributeCode();
diff --git a/lib/internal/Magento/Framework/MessageQueue/Topology/Config/Xml/Converter.php b/lib/internal/Magento/Framework/MessageQueue/Topology/Config/Xml/Converter.php
@@ -27,7 +27,6 @@ class Converter implements \Magento\Framework\Config\ConverterInterface, ResetAf
      * Boolean value converter.
      *
      * @var BooleanUtils
-     *
      * phpcs:disable Magento2.Commenting.ClassPropertyPHPDocFormatting
      */
     private readonly BooleanUtils $booleanUtils;
@@ -66,6 +65,7 @@ public function __construct(
     /**
      * @inheritdoc
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * phpcs:ignore Magento2.Performance.ForeachArrayMerge
      */
     public function convert($source)
     {
@@ -93,14 +93,12 @@ public function convert($source)
                 }
             }
 
-            // @codingStandardsIgnoreStart
             if (isset($result[$name . '--' . $connection]['bindings']) && count($bindings) > 0) {
                 $bindings = array_merge($result[$name . '--' . $connection]['bindings'], $bindings);
             }
             if (isset($result[$name . '--' . $connection]['arguments']) && count($exchangeArguments) > 0) {
                 $exchangeArguments = array_merge($result[$name . '--' . $connection]['arguments'], $exchangeArguments);
             }
-            // @codingStandardsIgnoreEnd
 
             $autoDelete = $this->getAttributeValue($exchange, 'autoDelete', false);
             $result[$name . '--' . $connection] = [
diff --git a/lib/internal/Magento/Framework/Model/ResourceModel/AbstractResource.php b/lib/internal/Magento/Framework/Model/ResourceModel/AbstractResource.php
@@ -82,7 +82,8 @@ public function addCommitCallback($callback)
     /**
      * Commit resource transaction
      *
-     * @deprecated @see \Magento\Framework\Model\ExecuteCommitCallbacks::afterCommit
+     * @deprecated
+     * @see \Magento\Framework\Model\ExecuteCommitCallbacks::afterCommit
      * @return $this
      */
     public function commit()
@@ -248,7 +249,8 @@ protected function _getColumnsForEntityLoad(\Magento\Framework\Model\AbstractMod
      * Get serializer
      *
      * @return Json
-     * @deprecated 101.0.0 @see not recommended anymore
+     * @deprecated 101.0.0
+     * @see not recommended anymore
      * @since 101.0.0
      */
     protected function getSerializer()
@@ -263,7 +265,8 @@ protected function getSerializer()
      * Get logger
      *
      * @return \Psr\Log\LoggerInterface
-     * @deprecated 101.0.1 @see not recommended anymore
+     * @deprecated 101.0.1
+     * @see not recommended anymore
      */
     private function getLogger()
     {
diff --git a/lib/internal/Magento/Framework/View/Asset/Source.php b/lib/internal/Magento/Framework/View/Asset/Source.php
@@ -48,7 +48,8 @@ class Source implements ResetAfterRequestInterface
 
     /**
      * @var \Magento\Framework\View\Design\Theme\ListInterface
-     * @deprecated 100.0.2 @see not recmomended anymore
+     * @deprecated 100.0.2
+     * @see not recmomended anymore
      */
     private $themeList;
 
@@ -286,7 +287,8 @@ private function findFile(LocalInterface $asset, \Magento\Framework\View\Asset\F
      * @param \Magento\Framework\View\Asset\LocalInterface $asset
      *
      * @return bool|string
-     * @deprecated 100.1.0 @see If custom vendor directory is outside Magento root,
+     * @deprecated 100.1.0
+     * @see If custom vendor directory is outside Magento root,
      * then this method will return unexpected result.
      */
     public function findRelativeSourceFilePath(LocalInterface $asset)

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ class PayflowProAdditionalDataProvider implements AdditionalDataProviderInterfac`
`18`	`18`	`{`
`19`	`19`	`/**`
`20`	`20`	`* @param ArrayManager $arrayManager`
`21`		`- *`
	`21`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`22`	`22`	`* phpcs:disable Magento2.CodeAnalysis.EmptyBlock`
`23`	`23`	`*/`
`24`	`24`	`public function __construct(ArrayManager $arrayManager)`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ class CustomizableOptionsDataProvider implements BuyRequestDataProviderInterface`
`18`	`18`	`{`
`19`	`19`	`/**`
`20`	`20`	`* @var ArrayManagerFactory`
`21`		`- *`
	`21`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`22`	`22`	`* phpcs:disable Magento2.Commenting.ClassPropertyPHPDocFormatting`
`23`	`23`	`*/`
`24`	`24`	`private readonly ArrayManagerFactory $arrayManagerFactory;`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ class QuantityDataProvider implements BuyRequestDataProviderInterface`
`19`	`19`	`{`
`20`	`20`	`/**`
`21`	`21`	`* @var ArrayManagerFactory`
`22`		`- *`
	`22`	`+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`23`	`23`	`* phpcs:disable Magento2.Commenting.ClassPropertyPHPDocFormatting`
`24`	`24`	`*/`
`25`	`25`	`private readonly ArrayManagerFactory $arrayManagerFactory;`
Original file line number	Diff line number	Diff line change
`@@ -88,11 +88,11 @@ protected function _beforeSaveAttribute(AbstractModel $object, $attribute)`
`88`	`88`	`* Perform actions after object save`
`89`	`89`	`*`
`90`	`90`	`* @param AbstractModel $object`
`91`		`- * @param string $attribute`
	`91`	`+ * @param mixed $attribute`
`92`	`92`	`* @return $this`
`93`	`93`	`* @throws \Exception`
`94`	`94`	`*/`
`95`		`- public function saveAttribute(AbstractModel $object, $attribute)`
	`95`	`+ public function saveAttribute(AbstractModel $object, mixed $attribute)`
`96`	`96`	`{`
`97`	`97`	`if ($attribute instanceof AbstractAttribute) {`
`98`	`98`	`$attributes = $attribute->getAttributeCode();`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@ class Converter implements \Magento\Framework\Config\ConverterInterface, ResetAf`
`27`	`27`	`* Boolean value converter.`
`28`	`28`	`*`
`29`	`29`	`* @var BooleanUtils`
`30`		`- *`
`31`	`30`	`* phpcs:disable Magento2.Commenting.ClassPropertyPHPDocFormatting`
`32`	`31`	`*/`
`33`	`32`	`private readonly BooleanUtils $booleanUtils;`
`@@ -66,6 +65,7 @@ public function __construct(`
`66`	`65`	`/**`
`67`	`66`	`* @inheritdoc`
`68`	`67`	`* @SuppressWarnings(PHPMD.CyclomaticComplexity)`
	`68`	`+ * phpcs:ignore Magento2.Performance.ForeachArrayMerge`
`69`	`69`	`*/`
`70`	`70`	`public function convert($source)`
`71`	`71`	`{`
`@@ -93,14 +93,12 @@ public function convert($source)`
`93`	`93`	`}`
`94`	`94`	`}`
`95`	`95`
`96`		`- // @codingStandardsIgnoreStart`
`97`	`96`	`if (isset($result[$name . '--' . $connection]['bindings']) && count($bindings) > 0) {`
`98`	`97`	`$bindings = array_merge($result[$name . '--' . $connection]['bindings'], $bindings);`
`99`	`98`	`}`
`100`	`99`	`if (isset($result[$name . '--' . $connection]['arguments']) && count($exchangeArguments) > 0) {`
`101`	`100`	`$exchangeArguments = array_merge($result[$name . '--' . $connection]['arguments'], $exchangeArguments);`
`102`	`101`	`}`
`103`		`- // @codingStandardsIgnoreEnd`
`104`	`102`
`105`	`103`	`$autoDelete = $this->getAttributeValue($exchange, 'autoDelete', false);`
`106`	`104`	`$result[$name . '--' . $connection] = [`