Skip to content

Commit 6b8ecfe

Browse files
committed
Fix functional tests
1 parent 720a5dc commit 6b8ecfe

File tree

2 files changed

+26
-25
lines changed

2 files changed

+26
-25
lines changed

dev/tests/functional/tests/app/Magento/ProductVideo/Test/Repository/ConfigData.xml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,21 @@
2323
<item name="value" xsi:type="string"/>
2424
</field>
2525
</dataset>
26+
<dataset name="play_if_base">
27+
<field name="catalog/product_video/play_if_base" xsi:type="array">
28+
<item name="scope" xsi:type="string">default</item>
29+
<item name="scope_id" xsi:type="number">0</item>
30+
<item name="label" xsi:type="string">Yes</item>
31+
<item name="value" xsi:type="string">0</item>
32+
</field>
33+
</dataset>
34+
<dataset name="play_if_base_rollback">
35+
<field name="catalog/product_video/play_if_base" xsi:type="array">
36+
<item name="scope" xsi:type="string">default</item>
37+
<item name="scope_id" xsi:type="number">0</item>
38+
<item name="label" xsi:type="string">Yes</item>
39+
<item name="value" xsi:type="string">1</item>
40+
</field>
41+
</dataset>
2642
</repository>
2743
</config>

dev/tests/functional/tests/app/Magento/ProductVideo/Test/TestCase/UpdateSimpleProductEntityTest.xml

Lines changed: 10 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -7,34 +7,14 @@
77
-->
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/mtf/etc/variations.xsd">
99
<testCase name="Magento\Catalog\Test\TestCase\Product\UpdateSimpleProductEntityTest" summary="Add Video to PCF" ticketId="PV-1">
10-
<variation name="DeleteVideoFromPCFTestVariation1">
11-
<data name="description" xsi:type="string">Delete video youtube</data>
12-
<data name="initialProduct/dataset" xsi:type="string">product_with_video_youtube</data>
13-
<data name="product/data/sku" xsi:type="string">sku_simple_product_with_video_%isolation%</data>
14-
<data name="product/data/media_gallery/images" xsi:type="string" />
15-
<constraint name="Magento\Catalog\Test\Constraint\AssertProductNoImageInGrid" />
16-
<constraint name="Magento\Catalog\Test\Constraint\AssertProductForm" />
17-
<constraint name="Magento\ProductVideo\Test\Constraint\AssertNoVideoCategoryView" />
18-
<constraint name="Magento\ProductVideo\Test\Constraint\AssertNoVideoProductView" />
19-
</variation>
20-
<variation name="DeleteVideoFromPCFTestVariation2">
21-
<data name="description" xsi:type="string">Delete video vimeo</data>
22-
<data name="initialProduct/dataset" xsi:type="string">product_with_video_vimeo</data>
23-
<data name="product/data/sku" xsi:type="string">sku_simple_product_with_video_%isolation%</data>
24-
<data name="product/data/media_gallery/images" xsi:type="string" />
25-
<constraint name="Magento\Catalog\Test\Constraint\AssertProductNoImageInGrid" />
26-
<constraint name="Magento\Catalog\Test\Constraint\AssertProductForm" />
27-
<constraint name="Magento\ProductVideo\Test\Constraint\AssertNoVideoCategoryView" />
28-
<constraint name="Magento\ProductVideo\Test\Constraint\AssertNoVideoProductView" />
29-
</variation>
3010
<variation name="AddVideoToPCFTestVariation1">
3111
<data name="description" xsi:type="string">Add youtube video with all available fields filled in</data>
3212
<data name="initialProduct/dataset" xsi:type="string">product_with_category</data>
3313
<data name="product/data/sku" xsi:type="string">simple_product_with_category_%isolation%</data>
3414
<data name="product/data/media_gallery/images/0/video_url" xsi:type="string">https://youtu.be/WMp2PvU2qi8</data>
3515
<data name="product/data/media_gallery/images/0/video_title" xsi:type="string">Foo Test 1</data>
3616
<data name="product/data/media_gallery/images/0/video_description" xsi:type="string">This is a test "Foo Test 1"</data>
37-
<data name="configData" xsi:type="string">youtube_api_key</data>
17+
<data name="configData" xsi:type="string">play_if_base,youtube_api_key</data>
3818
<constraint name="Magento\ProductVideo\Test\Constraint\AssertVideoCategoryView" />
3919
<constraint name="Magento\ProductVideo\Test\Constraint\AssertVideoProductView" />
4020
<constraint name="Magento\Catalog\Test\Constraint\AssertProductForm" />
@@ -46,6 +26,7 @@
4626
<data name="product/data/media_gallery/images/0/video_url" xsi:type="string">https://vimeo.com/21776334</data>
4727
<data name="product/data/media_gallery/images/0/video_title" xsi:type="string">Foo Test 2</data>
4828
<data name="product/data/media_gallery/images/0/video_description" xsi:type="string">This is a test "Foo Test 2"</data>
29+
<data name="configData" xsi:type="string">play_if_base</data>
4930
<constraint name="Magento\ProductVideo\Test\Constraint\AssertVideoCategoryView" />
5031
<constraint name="Magento\ProductVideo\Test\Constraint\AssertVideoProductView" />
5132
<constraint name="Magento\Catalog\Test\Constraint\AssertProductForm" />
@@ -56,7 +37,7 @@
5637
<data name="product/data/sku" xsi:type="string">sku_simple_product_with_video_%isolation%</data>
5738
<data name="product/data/media_gallery/images/0/video_url" xsi:type="string">https://youtu.be/WMp2PvU2qi8</data>
5839
<data name="product/data/media_gallery/images/0/video_title" xsi:type="string">Foo Test 1</data>
59-
<data name="configData" xsi:type="string">youtube_api_key</data>
40+
<data name="configData" xsi:type="string">youtube_api_key,play_if_base</data>
6041
<constraint name="Magento\ProductVideo\Test\Constraint\AssertVideoCategoryView" />
6142
<constraint name="Magento\ProductVideo\Test\Constraint\AssertVideoProductView" />
6243
<constraint name="Magento\Catalog\Test\Constraint\AssertProductForm" />
@@ -66,6 +47,7 @@
6647
<data name="product/data/sku" xsi:type="string">simple_product_with_category_%isolation%</data>
6748
<data name="product/data/media_gallery/images/0/video_url" xsi:type="string">https://vimeo.com/21776334</data>
6849
<data name="product/data/media_gallery/images/0/video_title" xsi:type="string">Foo Test 2</data>
50+
<data name="configData" xsi:type="string">play_if_base</data>
6951
<constraint name="Magento\ProductVideo\Test\Constraint\AssertVideoCategoryView" />
7052
<constraint name="Magento\ProductVideo\Test\Constraint\AssertVideoProductView" />
7153
<constraint name="Magento\Catalog\Test\Constraint\AssertProductForm" />
@@ -75,14 +57,15 @@
7557
<data name="initialProduct/dataset" xsi:type="string">product_with_video_youtube</data>
7658
<data name="product/data/sku" xsi:type="string">sku_simple_product_with_video_%isolation%</data>
7759
<data name="product/data/media_gallery/images/0/video_url" xsi:type="string">https://youtu.be/bpOSxM0rNPM</data>
78-
<data name="configData" xsi:type="string">youtube_api_key</data>
60+
<data name="configData" xsi:type="string">youtube_api_key,play_if_base</data>
7961
<constraint name="Magento\Catalog\Test\Constraint\AssertProductForm" />
8062
</variation>
8163
<variation name="UpdateVideoInPCFTestVariation2">
8264
<data name="description" xsi:type="string">Edit vimeo URL</data>
8365
<data name="initialProduct/dataset" xsi:type="string">product_with_video_youtube</data>
8466
<data name="product/data/sku" xsi:type="string">sku_simple_product_with_video_%isolation%</data>
8567
<data name="productVideo/data/media_gallery/images/0/video_url" xsi:type="string">https://vimeo.com/16342611</data>
68+
<data name="configData" xsi:type="string">play_if_base</data>
8669
<constraint name="Magento\Catalog\Test\Constraint\AssertProductForm" />
8770
</variation>
8871
<variation name="UpdateVideoInPCFTestVariation3">
@@ -91,6 +74,7 @@
9174
<data name="product/data/sku" xsi:type="string">sku_simple_product_with_video_%isolation%</data>
9275
<data name="productVideo/data/media_gallery/images/0/video_title" xsi:type="string">Edit Test</data>
9376
<data name="productVideo/data/media_gallery/images/0/video_description" xsi:type="string">This is an edit test</data>
77+
<data name="configData" xsi:type="string">play_if_base</data>
9478
<constraint name="Magento\Catalog\Test\Constraint\AssertProductForm" />
9579
</variation>
9680
<variation name="UpdateVideoInPCFTestVariation4">
@@ -100,7 +84,7 @@
10084
<data name="productVideo/data/media_gallery/images/0/video_url" xsi:type="string">https://youtu.be/bpOSxM0rNPM</data>
10185
<data name="productVideo/data/media_gallery/images/0/video_title" xsi:type="string">Edit Test</data>
10286
<data name="productVideo/data/media_gallery/images/0/video_description" xsi:type="string">This is an edit test</data>
103-
<data name="configData" xsi:type="string">youtube_api_key</data>
87+
<data name="configData" xsi:type="string">youtube_api_key,play_if_base</data>
10488
<constraint name="Magento\Catalog\Test\Constraint\AssertProductForm" />
10589
</variation>
10690
<variation name="GetVideoInfoTestVariation1">
@@ -109,7 +93,7 @@
10993
<data name="product/data/sku" xsi:type="string">simple_product_with_category_%isolation%</data>
11094
<data name="product/data/media_gallery/images/0/video_url" xsi:type="string">https://youtu.be/WMp2PvU2qi8</data>
11195
<data name="video/video_title" xsi:type="string">Foo Fighters - Congregation</data>
112-
<data name="configData" xsi:type="string">youtube_api_key</data>
96+
<data name="configData" xsi:type="string">youtube_api_key,play_if_base</data>
11397
<constraint name="Magento\ProductVideo\Test\Constraint\AssertGetVideoInfoDataIsCorrect" />
11498
</variation>
11599
<variation name="GetVideoInfoTestVariation2">
@@ -118,6 +102,7 @@
118102
<data name="product/data/sku" xsi:type="string">simple_product_with_category_%isolation%</data>
119103
<data name="product/data/media_gallery/images/0/video_url" xsi:type="string">https://vimeo.com/21776334</data>
120104
<data name="video/video_title" xsi:type="string">Foo Fighters - "Walk" - Official Music Video (HD)</data>
105+
<data name="configData" xsi:type="string">play_if_base</data>
121106
<constraint name="Magento\ProductVideo\Test\Constraint\AssertGetVideoInfoDataIsCorrect" />
122107
</variation>
123108
</testCase>

0 commit comments

Comments
 (0)