#37953: Attribute getStoreLabel wrong behavior

Kiraberos · Kiraberos · commit 6b7a5592499f · 2023-10-13T11:46:51.000+03:00
- fixed issue with wrong behaviour of the store labels
diff --git a/app/code/Magento/Eav/Model/Entity/Attribute.php b/app/code/Magento/Eav/Model/Entity/Attribute.php
@@ -489,7 +489,7 @@ public function getStoreLabels()
      */
     public function getStoreLabel($storeId = null)
     {
-        if ($this->hasData('store_label')) {
+        if ($this->hasData('store_label') && $storeId === null) {
             return $this->getData('store_label');
         }
         $store = $this->_storeManager->getStore($storeId);

Original file line number	Diff line number	Diff line change
`@@ -489,7 +489,7 @@ public function getStoreLabels()`
`489`	`489`	`*/`
`490`	`490`	`public function getStoreLabel($storeId = null)`
`491`	`491`	`{`
`492`		`- if ($this->hasData('store_label')) {`
	`492`	`+ if ($this->hasData('store_label') && $storeId === null) {`
`493`	`493`	`return $this->getData('store_label');`
`494`	`494`	`}`
`495`	`495`	`$store = $this->_storeManager->getStore($storeId);`