Merge branch 'MC-40051' into 2.4-develop-sidecar-pr13

Author: ysapiga

dev/tests/api-functional/testsuite/Magento/ConfigurableProduct/Api/OptionRepositoryTest.php

@@ -4,6 +4,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\ConfigurableProduct\Api;
 
@@ -21,8 +22,10 @@ class OptionRepositoryTest extends \Magento\TestFramework\TestCase\WebapiAbstrac
 
     /**
      * @magentoApiDataFixture Magento/ConfigurableProduct/_files/product_configurable.php
+     *
+     * @return void
      */
-    public function testGet()
+    public function testGet(): void
     {
         $productSku = 'configurable';
 
@@ -54,8 +57,10 @@ public function testGet()
 
     /**
      * @magentoApiDataFixture Magento/ConfigurableProduct/_files/product_configurable.php
+     *
+     * @return void
      */
-    public function testGetList()
+    public function testGetList(): void
     {
         $productSku = 'configurable';
 
@@ -90,8 +95,9 @@ public function testGetList()
     }
 
     /**
+     * @return void
      */
-    public function testGetUndefinedProduct()
+    public function testGetUndefinedProduct(): void
     {
         $this->expectException(\Exception::class);
         $this->expectExceptionMessage(
@@ -104,8 +110,10 @@ public function testGetUndefinedProduct()
 
     /**
      * @magentoApiDataFixture Magento/ConfigurableProduct/_files/product_configurable.php
+     *
+     * @return void
      */
-    public function testGetUndefinedOption()
+    public function testGetUndefinedOption(): void
     {
         $expectedMessage = 'The "%1" entity that was requested doesn\'t exist. Verify the entity and try again.';
         $productSku = 'configurable';
@@ -127,8 +135,10 @@ public function testGetUndefinedOption()
 
     /**
      * @magentoApiDataFixture Magento/ConfigurableProduct/_files/product_configurable.php
+     *
+     * @return void
      */
-    public function testDelete()
+    public function testDelete(): void
     {
         $productSku = 'configurable';
 
@@ -144,8 +154,10 @@ public function testDelete()
     /**
      * @magentoApiDataFixture Magento/Catalog/_files/product_simple.php
      * @magentoApiDataFixture Magento/ConfigurableProduct/_files/configurable_attribute.php
+     *
+     * @return void
      */
-    public function testAdd()
+    public function testAdd(): void
     {
         /** @var AttributeRepositoryInterface $attributeRepository */
         $attributeRepository = Bootstrap::getObjectManager()->create(AttributeRepositoryInterface::class);
@@ -181,8 +193,10 @@ public function testAdd()
 
     /**
      * @magentoApiDataFixture Magento/ConfigurableProduct/_files/product_configurable.php
+     *
+     * @return void
      */
-    public function testUpdate()
+    public function testUpdate(): void
     {
         $productSku = 'configurable';
         $configurableAttribute = $this->getConfigurableAttribute($productSku);
@@ -218,8 +232,10 @@ public function testUpdate()
 
     /**
      * @magentoApiDataFixture Magento/ConfigurableProduct/_files/product_configurable.php
+     *
+     * @return void
      */
-    public function testUpdateWithoutOptionId()
+    public function testUpdateWithoutOptionId(): void
     {
         $productSku = 'configurable';
         /** @var AttributeRepositoryInterface $attributeRepository */
@@ -257,6 +273,19 @@ public function testUpdateWithoutOptionId()
         $this->assertEquals($option['label'], $configurableAttribute[0]['label']);
     }
 
+    /**
+     * @magentoApiDataFixture Magento/ConfigurableProduct/_files/product_configurable.php
+     *
+     * @return void
+     */
+    public function testDeleteNotExistsOption(): void
+    {
+        $message = (string)__('The option that was requested doesn\'t exist. Verify the entity and try again.');
+        $this->expectExceptionMessage($message);
+        $this->expectException(\Exception::class);
+        $this->delete('configurable', 555);
+    }
+
     /**
      * @param string $productSku
      * @return array