Skip to content

Commit 6b559a3

Browse files
committed
MC-33231: Stabilize Integration tests to work with elasticsearch
- Added jenkins static failures fixes
1 parent c9e8781 commit 6b559a3

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

dev/tests/integration/testsuite/Magento/Catalog/Block/Product/ListProduct/SortingTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ public function productListSortOrderDataProviderOnStoreView(): array
303303
'sort' => 'test_configurable',
304304
'direction' => 'desc',
305305
'expectation' => ['simple3', 'simple2', 'simple1'],
306-
'default_sort' => 'price',
306+
'default_sort' => 'price',
307307
'incomplete_reason' => 'MC-33825:'
308308
. 'Stabilize skipped test cases for Integration SortingTest with elasticsearch',
309309
],

dev/tests/integration/testsuite/Magento/Catalog/Model/Layer/Filter/DataProvider/PriceTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public function testGetMaxPriceInt()
7171
public function getRangeItemCountsDataProvider()
7272
{
7373
return [
74-
//[$inputRange, [$expectedItemCounts]]
74+
// These are $inputRange, [$expectedItemCounts] values
7575
[1, [11 => 2, 46 => 1, 16 => '1']],
7676
[10, [2 => 3, 5 => 1]],
7777
[20, [1 => 3, 3 => 1]],

dev/tests/integration/testsuite/Magento/Catalog/Model/Layer/Filter/Price/AlgorithmBaseTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ public function testPricesSegmentation($categoryId, array $entityIds, array $int
123123

124124
// Algorithm should use less than 10M
125125
$this->assertLessThan(10 * 1024 * 1024, memory_get_usage() - $memoryUsedBefore);
126+
126127
}
127128

128129
/**

lib/internal/Magento/Framework/Search/Dynamic/Algorithm.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ public function calculateSeparators(IntervalInterface $interval)
173173
$lastCount = 0;
174174
$intervalFirstValue = $this->_minValue;
175175
$lastSeparator = $this->_lowerLimit === null ? 0 : $this->_lowerLimit;
176-
176+
// phpcs:ignore Generic.CodeAnalysis.ForLoopWithTestFunctionCall
177177
for ($intervalNumber = 1; $intervalNumber < $this->getIntervalsNumber(); ++$intervalNumber) {
178178
$separator = $this->_findValueSeparator($intervalNumber, $interval);
179179
if (empty($separator)) {
@@ -602,9 +602,8 @@ protected function _binarySearch($value, $limits = null)
602602
/**
603603
* Get the offsetLimit value
604604
*
605-
* @param $intervalValuesCount
606-
* @param $values
607-
* @return mixed
605+
* @param float|int $intervalValuesCount
606+
* @param array $values
608607
*/
609608
private function offsetLimits($intervalValuesCount, $values)
610609
{

0 commit comments

Comments
 (0)