Skip to content

Commit 6b29dff

Browse files
committed
Merge branch '2.3-develop-php74' of https://github.com/magento-commerce/magento2ce into MC-40559
2 parents 73f41dc + 518c9eb commit 6b29dff

File tree

4 files changed

+12
-27
lines changed

4 files changed

+12
-27
lines changed

app/code/Magento/Catalog/etc/di.xml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -671,14 +671,6 @@
671671
<item name="store" xsi:type="string">Magento\Store\Model\StoreScopeProvider</item>
672672
</item>
673673
</item>
674-
<item name="Magento\Catalog\Api\Data\CategoryTreeInterface" xsi:type="array">
675-
<item name="entityTableName" xsi:type="string">catalog_category_entity</item>
676-
<item name="eavEntityType" xsi:type="string">catalog_category</item>
677-
<item name="identifierField" xsi:type="string">entity_id</item>
678-
<item name="entityContext" xsi:type="array">
679-
<item name="store" xsi:type="string">Magento\Store\Model\StoreScopeProvider</item>
680-
</item>
681-
</item>
682674
<item name="Magento\Catalog\Api\Data\CategoryLinkInterface" xsi:type="array">
683675
<item name="entityTableName" xsi:type="string">catalog_category_product</item>
684676
<item name="identifierField" xsi:type="string">entity_id</item>
@@ -846,11 +838,6 @@
846838
<item name="store" xsi:type="string">Magento\Store\Model\DefaultStoreScopeProvider</item>
847839
</item>
848840
</item>
849-
<item name="Magento\Catalog\Api\Data\CategoryTreeInterface" xsi:type="array">
850-
<item name="entityContext" xsi:type="array">
851-
<item name="store" xsi:type="string">Magento\Store\Model\DefaultStoreScopeProvider</item>
852-
</item>
853-
</item>
854841
</argument>
855842
</arguments>
856843
</virtualType>
@@ -877,10 +864,6 @@
877864
<arguments>
878865
<argument name="extensionActions" xsi:type="array">
879866
<item name="eav" xsi:type="array">
880-
<item name="Magento\Catalog\Api\Data\CategoryTreeInterface" xsi:type="array">
881-
<item name="create" xsi:type="string">Magento\Catalog\Model\ResourceModel\CreateHandler</item>
882-
<item name="update" xsi:type="string">Magento\Catalog\Model\ResourceModel\UpdateHandler</item>
883-
</item>
884867
<item name="Magento\Catalog\Api\Data\CategoryInterface" xsi:type="array">
885868
<item name="create" xsi:type="string">Magento\Catalog\Model\ResourceModel\CreateHandler</item>
886869
<item name="update" xsi:type="string">Magento\Catalog\Model\ResourceModel\UpdateHandler</item>
@@ -902,7 +885,6 @@
902885
<arguments>
903886
<argument name="hydrators" xsi:type="array">
904887
<item name="Magento\Catalog\Api\Data\CategoryInterface" xsi:type="string">Magento\Framework\EntityManager\AbstractModelHydrator</item>
905-
<item name="Magento\Catalog\Api\Data\CategoryTreeInterface" xsi:type="string">Magento\Framework\EntityManager\AbstractModelHydrator</item>
906888
<item name="Magento\Catalog\Api\Data\ProductInterface" xsi:type="string">Magento\Catalog\Model\Product\Hydrator</item>
907889
</argument>
908890
</arguments>

app/code/Magento/Customer/Ui/Component/Listing/Column/Confirmation.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function __construct(
4545
}
4646

4747
/**
48-
* {@inheritdoc}
48+
* @inheritdoc
4949
*/
5050
public function prepareDataSource(array $dataSource)
5151
{
@@ -66,7 +66,7 @@ public function prepareDataSource(array $dataSource)
6666
private function getFieldLabel(array $item)
6767
{
6868
$isConfirmationRequired = $this->accountConfirmation->isConfirmationRequired(
69-
$item['website_id'][0],
69+
$item['website_id'][0] ?? null,
7070
$item[$item['id_field_name']],
7171
$item['email']
7272
);

app/code/Magento/ImportExport/Ui/DataProvider/ExportFileDataProvider.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,9 @@ public function getData()
103103
$result['items'][]['file_name'] = $this->getPathToExportFile($this->fileIO->getPathInfo($file));
104104
}
105105

106-
$pageSize = (int) $this->request->getParam('paging')['pageSize'];
107-
$pageCurrent = (int) $this->request->getParam('paging')['current'];
106+
$paging = $this->request->getParam('paging');
107+
$pageSize = (int) ($paging['pageSize'] ?? 0);
108+
$pageCurrent = (int) ($paging['current'] ?? 0);
108109
$pageOffset = ($pageCurrent - 1) * $pageSize;
109110
$result['totalRecords'] = count($result['items']);
110111
$result['items'] = array_slice($result['items'], $pageOffset, $pageSize);

app/code/Magento/Swatches/Block/Adminhtml/Attribute/Edit/Options/Visual.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,13 @@ protected function reformatSwatchLabels($swatchStoreValue = null)
9494
}
9595
$newSwatch = [];
9696
foreach ($swatchStoreValue as $key => $value) {
97-
if ($value[0] == '#') {
98-
$newSwatch[$key] = 'background: '.$value;
99-
} elseif ($value[0] == '/') {
100-
$mediaUrl = $this->swatchHelper->getSwatchMediaUrl();
101-
$newSwatch[$key] = 'background: url('.$mediaUrl.$value.'); background-size: cover;';
97+
if (!empty($value) && is_string($value)) {
98+
if ($value[0] === '#') {
99+
$newSwatch[$key] = 'background: '.$value;
100+
} elseif ($value[0] === '/') {
101+
$mediaUrl = $this->swatchHelper->getSwatchMediaUrl();
102+
$newSwatch[$key] = 'background: url('.$mediaUrl.$value.'); background-size: cover;';
103+
}
102104
}
103105
}
104106
return $newSwatch;

0 commit comments

Comments
 (0)