Skip to content

Commit 6af00d1

Browse files
committed
Merge remote-tracking branch 'jackalopes/MAGETWO-70738-mail-transport' into Okapis-PR
2 parents 70b8191 + a55876f commit 6af00d1

File tree

7 files changed

+52
-12
lines changed

7 files changed

+52
-12
lines changed

app/code/Magento/Sales/Test/Unit/Model/Order/Email/Stub/TransportInterfaceMock.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,14 @@ public function sendMessage()
1818
{
1919
return;
2020
}
21+
22+
/**
23+
* Get message
24+
*
25+
* @return string
26+
*/
27+
public function getMessage()
28+
{
29+
return '';
30+
}
2131
}

dev/tests/integration/framework/Magento/TestFramework/Mail/TransportInterfaceMock.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,14 @@ public function sendMessage()
1717
{
1818
return;
1919
}
20+
21+
/**
22+
* Get message
23+
*
24+
* @return string
25+
*/
26+
public function getMessage()
27+
{
28+
return '';
29+
}
2030
}

dev/tests/integration/testsuite/Magento/Customer/Controller/Adminhtml/IndexTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -762,8 +762,7 @@ protected function prepareEmailMock($occurrenceNumber, $templateId, $sender, $cu
762762
$storeId = $customer->getStoreId();
763763
$name = $this->customerViewHelper->getCustomerName($customer);
764764
$transportMock = $this->getMock(
765-
\Magento\Framework\Mail\TransportInterface::class,
766-
['sendMessage']
765+
\Magento\Framework\Mail\TransportInterface::class
767766
);
768767
$transportMock->expects($this->exactly($occurrenceNumber))
769768
->method('sendMessage');

dev/tests/integration/testsuite/Magento/User/Controller/Adminhtml/AuthTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,8 +268,7 @@ public function testResetPasswordPostActionWithInvalidPassword()
268268
protected function prepareEmailMock($occurrenceNumber, $templateId, $sender)
269269
{
270270
$transportMock = $this->getMock(
271-
\Magento\Framework\Mail\TransportInterface::class,
272-
['sendMessage']
271+
\Magento\Framework\Mail\TransportInterface::class
273272
);
274273
$transportMock->expects($this->exactly($occurrenceNumber))
275274
->method('sendMessage');

lib/internal/Magento/Framework/Mail/Test/Unit/TransportTest.php

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@ class TransportTest extends \PHPUnit_Framework_TestCase
1010
/**
1111
* @var \PHPUnit_Framework_MockObject
1212
*/
13-
protected $_messageMock;
13+
protected $messageMock;
1414

1515
/**
1616
* @var \Magento\Framework\Mail\Transport
1717
*/
18-
protected $_transport;
18+
protected $transport;
1919

2020
protected function setUp()
2121
{
22-
$this->_messageMock = $this->getMock(\Magento\Framework\Mail\Message::class, [], [], '', false);
23-
$this->_transport = new \Magento\Framework\Mail\Transport($this->_messageMock);
22+
$this->messageMock = $this->getMock(\Magento\Framework\Mail\Message::class, [], [], '', false);
23+
$this->transport = new \Magento\Framework\Mail\Transport($this->messageMock);
2424
}
2525

2626
/**
@@ -29,8 +29,8 @@ protected function setUp()
2929
*/
3030
public function testTransportWithIncorrectMessageObject()
3131
{
32-
$this->_messageMock = $this->getMock(\Magento\Framework\Mail\MessageInterface::class);
33-
$this->_transport = new \Magento\Framework\Mail\Transport($this->_messageMock);
32+
$this->messageMock = $this->getMock(\Magento\Framework\Mail\MessageInterface::class);
33+
$this->transport = new \Magento\Framework\Mail\Transport($this->messageMock);
3434
}
3535

3636
/**
@@ -40,10 +40,15 @@ public function testTransportWithIncorrectMessageObject()
4040
*/
4141
public function testSendMessageBrokenMessage()
4242
{
43-
$this->_messageMock->expects($this->any())
43+
$this->messageMock->expects($this->any())
4444
->method('getParts')
4545
->will($this->returnValue(['a', 'b']));
4646

47-
$this->_transport->sendMessage();
47+
$this->transport->sendMessage();
48+
}
49+
50+
public function testGetMessage()
51+
{
52+
$this->assertSame($this->messageMock, $this->transport->getMessage());
4853
}
4954
}

lib/internal/Magento/Framework/Mail/Transport.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,14 @@ public function sendMessage()
4141
throw new \Magento\Framework\Exception\MailException(new \Magento\Framework\Phrase($e->getMessage()), $e);
4242
}
4343
}
44+
45+
/**
46+
* Get message
47+
*
48+
* @return string
49+
*/
50+
public function getMessage()
51+
{
52+
return $this->_message;
53+
}
4454
}

lib/internal/Magento/Framework/Mail/TransportInterface.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,11 @@ interface TransportInterface
1919
* @throws \Magento\Framework\Exception\MailException
2020
*/
2121
public function sendMessage();
22+
23+
/**
24+
* Get message
25+
*
26+
* @return string
27+
*/
28+
public function getMessage();
2229
}

0 commit comments

Comments
 (0)