Skip to content

Commit 6a94b59

Browse files
author
Stanislav Idolov
committed
#27499: Code review fixes
1 parent 9eecf12 commit 6a94b59

File tree

4 files changed

+3
-28
lines changed

4 files changed

+3
-28
lines changed

app/code/Magento/MediaGallery/Model/Directory/Config.php renamed to app/code/Magento/MediaGallery/Model/Directory/BlacklistPatternsConfig.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
/**
1414
* Media gallery directory config
1515
*/
16-
class Config implements BlacklistPatternsConfigInterface
16+
class BlacklistPatternsConfig implements BlacklistPatternsConfigInterface
1717
{
1818
private const XML_PATH_BLACKLIST_PATTERNS = 'blacklist/patterns';
1919

app/code/Magento/MediaGallery/Model/Directory/ConfigInterface.php

Lines changed: 0 additions & 21 deletions
This file was deleted.

app/code/Magento/MediaGallery/Test/Unit/Model/Directory/IsBlacklistedTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
1111
use Magento\MediaGallery\Model\Directory\IsBlacklisted;
12-
use Magento\MediaGallery\Model\Directory\Config;
1312
use Magento\MediaGalleryApi\Model\BlacklistPatternsConfigInterface;
1413
use PHPUnit\Framework\MockObject\MockObject;
1514
use PHPUnit\Framework\TestCase;

app/code/Magento/MediaGallery/etc/di.xml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@
99
<preference for="Magento\MediaGalleryApi\Api\Data\KeywordInterface" type="Magento\MediaGallery\Model\Keyword"/>
1010
<preference for="Magento\MediaGalleryApi\Api\Data\AssetInterface" type="Magento\MediaGallery\Model\Asset"/>
1111
<preference for="Magento\MediaGalleryApi\Api\Data\AssetKeywordsInterface" type="Magento\MediaGallery\Model\AssetKeywords"/>
12-
13-
<preference for="Magento\MediaGallery\Model\Directory\ConfigInterface" type="Magento\MediaGallery\Model\Directory\Config"/>
14-
1512
<preference for="Magento\MediaGalleryApi\Model\Asset\Command\GetByIdInterface" type="Magento\MediaGallery\Model\Asset\Command\GetById"/>
1613
<preference for="Magento\MediaGalleryApi\Model\Asset\Command\SaveInterface" type="Magento\MediaGallery\Model\Asset\Command\Save"/>
1714
<preference for="Magento\MediaGalleryApi\Model\Asset\Command\GetByPathInterface" type="Magento\MediaGallery\Model\Asset\Command\GetByPath"/>
@@ -53,11 +50,11 @@
5350
<argument name="cacheId" xsi:type="string">Media_Gallery_Patterns_CacheId</argument>
5451
</arguments>
5552
</virtualType>
56-
<type name="Magento\MediaGallery\Model\Directory\Config">
53+
<type name="Magento\MediaGallery\Model\Directory\BlacklistPatternsConfig">
5754
<arguments>
5855
<argument name="data" xsi:type="object">Magento\MediaGallery\Model\Directory\Config\Data</argument>
5956
</arguments>
6057
</type>
6158

62-
<preference for="Magento\MediaGalleryApi\Model\BlacklistPatternsConfigInterface" type="Magento\MediaGallery\Model\Directory\Config"/>
59+
<preference for="Magento\MediaGalleryApi\Model\BlacklistPatternsConfigInterface" type="Magento\MediaGallery\Model\Directory\BlacklistPatternsConfig"/>
6360
</config>

0 commit comments

Comments
 (0)