MAGETWO-51538: Exception when perform advanced search by space in any field

Author: Maksym Aposov

app/code/Magento/CatalogSearch/Model/ResourceModel/Fulltext/Collection.php

@@ -15,7 +15,6 @@
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\App\ObjectManager;
 
-
 /**
  * Fulltext Collection
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)

dev/tests/static/testsuite/Magento/Test/Integrity/_files/blacklist/exception_hierarchy.txt

@@ -1,3 +1,5 @@
 \Magento\Framework\Exception\LocalizedException
 \Magento\Framework\View\Asset\File\NotFoundException
 \Magento\Framework\Config\Dom\ValidationException
+\Magento\Framework\Search\Request\EmptyRequestDataException
+\Magento\Framework\Search\Request\NonExistingRequestNameException

lib/internal/Magento/Framework/Search/Request/Binder.php

@@ -70,7 +70,9 @@ private function processDimensions($data, $bindData)
      */
     private function processData($data, $bindData)
     {
-        array_walk_recursive($bindData, function (&$item) { $item = trim($item);});
+        array_walk_recursive($bindData, function (&$item) {
+            $item = trim($item);
+        });
         $bindData = array_filter($bindData);
         foreach ($data as $key => $value) {
             if (is_array($value)) {

lib/internal/Magento/Framework/Search/Request/Builder.php

@@ -7,6 +7,7 @@
 namespace Magento\Framework\Search\Request;
 
 use Magento\Framework\ObjectManagerInterface;
+use Magento\Framework\Phrase;
 use Magento\Framework\Search\RequestInterface;
 
 class Builder
@@ -33,6 +34,7 @@ class Builder
         'dimensions' => [],
         'placeholder' => [],
     ];
+
     /**
      * @var Cleaner
      */
@@ -130,7 +132,7 @@ public function create()
         /** @var array $data */
         $data = $this->config->get($requestName);
         if ($data === null) {
-            throw new NonExistingRequestNameException(__("Request name '{$requestName}' doesn't exist."));
+            throw new NonExistingRequestNameException(new Phrase("Request name '{$requestName}' doesn't exist."));
         }
 
         $data = $this->binder->bind($data, $this->data);

lib/internal/Magento/Framework/Search/Request/Cleaner.php

@@ -57,7 +57,7 @@ public function clean(array $requestData)
         $this->clear();
 
         if (empty($requestData['queries']) && empty($requestData['filters'])) {
-            throw new EmptyRequestDataException(__('Request query and filter is not set'));
+            throw new EmptyRequestDataException(new Phrase('Request query and filter is not set'));
         }
 
         return $requestData;

lib/internal/Magento/Framework/Search/Request/EmptyRequestDataException.php

@@ -8,4 +8,4 @@
 
 class EmptyRequestDataException extends \InvalidArgumentException
 {
-}
+}

lib/internal/Magento/Framework/Search/Request/NonExistingRequestNameException.php

@@ -8,4 +8,4 @@
 
 class NonExistingRequestNameException extends \InvalidArgumentException
 {
-}
+}