MTA-1814: Analyse functional test failures - Sprint 9

Author: Dmytro Aponasenko

dev/tests/functional/tests/app/Magento/Backend/Test/Block/Menu.php

@@ -90,11 +90,8 @@ public function navigate($menuItem)
         }
         $subMenuSelector = sprintf($this->subMenu, $mainMenu);
         $this->waitForElementVisible($subMenuSelector, Locator::SELECTOR_XPATH);
-        $subMenuItem = $this->_rootElement->find($subMenuSelector, Locator::SELECTOR_XPATH)
-            ->find(sprintf($this->subMenuItem, $subMenu), Locator::SELECTOR_XPATH);
-        if (!$subMenuItem->isVisible()) {
-            throw new \Exception('Submenu item "' . $subMenu . '" is not visible in "' . $mainMenu . '"');
-        }
+        $subMenuItem = $subMenuSelector . sprintf($this->subMenuItem, $subMenu);
+        $this->waitForElementVisible($subMenuItem, Locator::SELECTOR_XPATH);
         $subMenuItem->click();
         $this->waitForElementNotVisible($subMenuSelector, Locator::SELECTOR_XPATH);
     }

dev/tests/functional/tests/app/Magento/Bundle/Test/TestCase/CreateBundleProductEntityTest.xml

@@ -99,6 +99,7 @@
             <constraint name="Magento\Bundle\Test\Constraint\AssertBundleItemsOnProductPage" />
         </variation>
         <variation name="CreateBundleProductEntityTestVariation5">
+            <data name="issue" xsi:type="string">Bug: MAGETWO-35342</data>
             <data name="description" xsi:type="string">Create fixed bundle with all types options</data>
             <data name="product/data/url_key" xsi:type="string">bundle-product-%isolation%</data>
             <data name="product/data/name" xsi:type="string">BundleProduct %isolation%</data>
@@ -163,7 +164,6 @@
             <constraint name="Magento\Catalog\Test\Constraint\AssertProductSaveMessage" />
             <constraint name="Magento\Catalog\Test\Constraint\AssertProductInGrid" />
             <constraint name="Magento\Bundle\Test\Constraint\AssertBundleProductForm" />
-            <constraint name="Magento\Bundle\Test\Constraint\AssertBundleProductPage" />
             <constraint name="Magento\Catalog\Test\Constraint\AssertProductOutOfStock" />
             <constraint name="Magento\Bundle\Test\Constraint\AssertBundlePriceView" />
         </variation>

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Product/Edit/Tab/Attributes/Search.php

@@ -8,36 +8,43 @@
 
 use Magento\Mtf\Client\Element\SuggestElement;
 use Magento\Catalog\Test\Fixture\CatalogProductAttribute;
+use Magento\Mtf\Client\Locator;
 
 /**
- * Class FormAttributeSearch
- * Form Attribute Search on Product page
+ * Form Attribute Search on Product page.
  */
 class Search extends SuggestElement
 {
     /**
-     * Attribute Set locator
+     * Attributes locator.
      *
      * @var string
      */
     protected $value = '.action-toggle > span';
 
     /**
-     * Attribute Set button
+     * Attributes button.
      *
      * @var string
      */
     protected $actionToggle = '.action-toggle';
 
     /**
-     * Search attribute result locator
+     * Saerch result dropdown.
      *
      * @var string
      */
-    protected $searchResult = '.mage-suggest-dropdown .ui-corner-all';
+    protected $searchResult = '.mage-suggest-dropdown';
 
     /**
-     * Set value
+     * Searched attribute result locator.
+     *
+     * @var string
+     */
+    protected $searchArrtibute = './/a[text()="%s"]';
+
+    /**
+     * Set value.
      *
      * @param string $value
      * @return void
@@ -49,7 +56,7 @@ public function setValue($value)
     }
 
     /**
-     * Get value
+     * Get value.
      *
      * @return string
      */
@@ -59,7 +66,7 @@ public function getValue()
     }
 
     /**
-     * Checking not exist attribute in search result
+     * Checking not exist attribute in search result.
      *
      * @param CatalogProductAttribute $productAttribute
      * @return bool
@@ -69,10 +76,24 @@ public function isExistAttributeInSearchResult($productAttribute)
         $this->find($this->actionToggle)->click();
         $this->find($this->suggest)->setValue($productAttribute->getFrontendLabel());
         $this->waitResult();
-        if ($this->find($this->searchResult)->getText() == $productAttribute->getFrontendLabel()) {
-            return true;
-        }
+        $attributeSelector = sprintf($this->searchArrtibute, $productAttribute->getFrontendLabel());
+        return $this->find($this->searchResult)->find($attributeSelector, Locator::SELECTOR_XPATH)->isVisible();
+    }
 
-        return false;
+    /**
+     * Wait for search result is visible.
+     *
+     * @return void
+     */
+    public function waitResult()
+    {
+        $browser = $this;
+        $selector = $this->searchResult;
+        $browser->waitUntil(
+            function () use ($browser, $selector) {
+                $element = $browser->find($selector);
+                return $element->isVisible() ? true : null;
+            }
+        );
     }
 }

dev/tests/functional/tests/app/Magento/ConfigurableProduct/Test/Block/Adminhtml/Product/Edit/Tab/Super/Config/Attribute.php

@@ -166,10 +166,8 @@ protected function createNewVariationSet(array $attribute)
 
         $this->_rootElement->find($this->createNewVariationSet)->click();
         $newAttribute = $this->getEditAttributeForm();
-        $newAttribute->fill($attributeFixture);
-        $newAttribute->_rootElement->find($this->saveAttribute)->click();
-
-        $this->browser->switchToFrame();
+        $this->getEditAttributeForm()->fill($attributeFixture);
+        $this->getEditAttributeForm()->saveAttributeForm();
     }
 
     /**

dev/tests/functional/tests/app/Magento/Customer/Test/TestStep/LoginCustomerOnFrontendStep.php

@@ -64,7 +64,7 @@ public function run()
         $this->cmsIndex->getCmsPageBlock()->waitPageInit();
         if ($this->cmsIndex->getLinksBlock()->isLinkVisible("Log Out")) {
             $this->cmsIndex->getLinksBlock()->openLink("Log Out");
-            $this->cmsIndex->getCmsPageBlock()->waitUntilTextIsVisible('Home Page');
+            $this->cmsIndex->getCmsPageBlock()->waitPageInit();
         }
         $this->cmsIndex->getLinksBlock()->openLink("Log In");
         $this->cmsIndex->getCmsPageBlock()->waitPageInit();