Skip to content

Commit 6930d43

Browse files
author
Natalia Momotenko
committed
Merge remote-tracking branch 'origin/develop' into bugfixes
2 parents b990fe3 + c29f3e7 commit 6930d43

File tree

35 files changed

+780
-71
lines changed

35 files changed

+780
-71
lines changed

app/code/Magento/Authorizenet/Controller/Directpost/Payment/Place.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
use Magento\Framework\Registry;
1616
use Magento\Payment\Model\IframeConfigProvider;
1717
use Magento\Quote\Api\CartManagementInterface;
18+
use Magento\Framework\Exception\LocalizedException;
1819

1920
/**
2021
* Class Place
@@ -125,6 +126,9 @@ protected function placeCheckoutOrder()
125126
'action' => $this
126127
]
127128
);
129+
} catch (LocalizedException $exception) {
130+
$result->setData('error', true);
131+
$result->setData('error_messages', $exception->getMessage());
128132
} catch (\Exception $exception) {
129133
$result->setData('error', true);
130134
$result->setData('error_messages', __('Unable to place order. Please try again later.'));

app/code/Magento/Catalog/Model/ResourceModel/AbstractResource.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,7 @@ public function getAttributeRawValue($entityId, $attribute, $store)
502502
$staticTable,
503503
$staticAttributes
504504
)->join(
505-
['e' => $this->getTable('catalog_product_entity')],
505+
['e' => $this->getTable($this->getEntityTable())],
506506
'e.' . $this->getLinkField() . ' = ' . $staticTable . '.' . $this->getLinkField()
507507
)->where(
508508
'e.entity_id = :entity_id'
@@ -523,7 +523,7 @@ public function getAttributeRawValue($entityId, $attribute, $store)
523523
$select = $connection->select()
524524
->from(['default_value' => $table], ['attribute_id'])
525525
->join(
526-
['e' => $this->getTable('catalog_product_entity')],
526+
['e' => $this->getTable($this->getEntityTable())],
527527
'e.' . $this->getLinkField() . ' = ' . 'default_value.' . $this->getLinkField(),
528528
''
529529
)->where('default_value.attribute_id IN (?)', array_keys($_attributes))

app/code/Magento/CatalogInventory/Ui/DataProvider/Product/Form/Modifier/AdvancedInventory.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,6 @@ private function prepareMeta()
213213
'dataScope' => 'qty',
214214
'validation' => [
215215
'validate-number' => true,
216-
'validate-digits' => true,
217216
'less-than-equals-to' => StockDataFilter::MAX_QTY_VALUE,
218217
],
219218
'imports' => [

app/code/Magento/CatalogInventory/view/adminhtml/ui_component/product_form.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@
9595
<item name="dataScope" xsi:type="string">quantity_and_stock_status.qty</item>
9696
<item name="validation" xsi:type="array">
9797
<item name="validate-number" xsi:type="boolean">true</item>
98-
<item name="validate-digits" xsi:type="boolean">true</item>
9998
<item name="less-than-equals-to" xsi:type="number">99999999</item>
10099
</item>
101100
<item name="sortOrder" xsi:type="number">200</item>

app/code/Magento/CatalogInventory/view/adminhtml/web/js/components/qty-validator-changer.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ define([
1919
handleChanges: function (value) {
2020
var isDigits = value !== 1;
2121

22-
this.validation['validate-number'] = !isDigits;
23-
this.validation['validate-digits'] = isDigits;
22+
this.validation['validate-integer'] = isDigits;
2423
this.validation['less-than-equals-to'] = isDigits ? 99999999 : 99999999.9999;
2524
this.validate();
2625
}

app/code/Magento/Checkout/Block/Cart/Link.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public function getHref()
6565
*/
6666
protected function _toHtml()
6767
{
68-
if ($this->_moduleManager->isOutputEnabled('Magento_Checkout')) {
68+
if (!$this->_moduleManager->isOutputEnabled('Magento_Checkout')) {
6969
return '';
7070
}
7171
return parent::_toHtml();

app/code/Magento/Checkout/Test/Unit/Block/Cart/LinkTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public function testToHtml()
5757
)->with(
5858
'Magento_Checkout'
5959
)->will(
60-
$this->returnValue(true)
60+
$this->returnValue(false)
6161
);
6262
$this->assertSame('', $block->toHtml());
6363
}

app/code/Magento/Checkout/view/frontend/web/js/view/shipping.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ define(
242242
emailValidationResult = customer.isLoggedIn();
243243

244244
if (!quote.shippingMethod()) {
245-
this.errorValidationMessage('Please specify a shipping method.');
245+
this.errorValidationMessage($.mage.__('Please specify a shipping method.'));
246246

247247
return false;
248248
}

app/code/Magento/Cms/Controller/Adminhtml/Page/MassDelete.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,13 @@
1515
*/
1616
class MassDelete extends \Magento\Backend\App\Action
1717
{
18+
/**
19+
* Authorization level of a basic admin session
20+
*
21+
* @see _isAllowed()
22+
*/
23+
const ADMIN_RESOURCE = 'Magento_Cms::page_delete';
24+
1825
/**
1926
* @var Filter
2027
*/

app/code/Magento/Cms/etc/frontend/page_types.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<type id="cms_index_defaultindex" label="CMS Home Default Page"/>
1010
<type id="cms_index_defaultnoroute" label="CMS No-Route Default Page"/>
1111
<type id="cms_index_index" label="CMS Home Page"/>
12-
<type id="cms_index_test" label="CMS Home Page"/>
1312
<type id="cms_index_nocookies" label="CMS No-Cookies Page"/>
1413
<type id="cms_index_noroute" label="CMS No-Route Page"/>
1514
<type id="cms_page_view" label="CMS Pages (All)"/>

0 commit comments

Comments
 (0)