ACP2E-2093: Issue when uploading image with the same name while deleting the old image

 - Fixed the database compare issue.

Author: devarul

app/code/Magento/Catalog/Model/Product/Image/RemoveDeletedImagesFromCache.php

@@ -88,32 +88,34 @@ public function __construct(
      */
     public function removeDeletedImagesFromCache(array $files)
     {
-        $imageArguments = $this->presentationConfig
-            ->getViewConfig(['area' => \Magento\Framework\App\Area::AREA_FRONTEND])
-            ->getMediaAttributes(
-                'Magento_Catalog',
-                Image::MEDIA_TYPE_CONFIG_NODE,
-                'product_page_image_small'
-            );
+        if (count($files) > 0) {
+            $imageArguments = $this->presentationConfig
+                ->getViewConfig(['area' => \Magento\Framework\App\Area::AREA_FRONTEND])
+                ->getMediaAttributes(
+                    'Magento_Catalog',
+                    Image::MEDIA_TYPE_CONFIG_NODE,
+                    'product_page_image_small'
+                );
 
-        $imageMiscParams = $this->imageParamsBuilder->build($imageArguments);
+            $imageMiscParams = $this->imageParamsBuilder->build($imageArguments);
 
-        if (isset($imageMiscParams['image_type'])) {
-            unset($imageMiscParams['image_type']);
-        }
+            if (isset($imageMiscParams['image_type'])) {
+                unset($imageMiscParams['image_type']);
+            }
 
-        $cacheId = $this->encryptor->hash(
-            implode('_', $this->convertImageMiscParamsToReadableFormat
-                ->convertImageMiscParamsToReadableFormat($imageMiscParams)),
-            Encryptor::HASH_VERSION_MD5
-        );
+            $cacheId = $this->encryptor->hash(
+                implode('_', $this->convertImageMiscParamsToReadableFormat
+                    ->convertImageMiscParamsToReadableFormat($imageMiscParams)),
+                Encryptor::HASH_VERSION_MD5
+            );
 
-        $catalogPath = $this->mediaConfig->getBaseMediaPath();
+            $catalogPath = $this->mediaConfig->getBaseMediaPath();
 
-        foreach ($files as $filePath) {
-            $this->mediaDirectory->delete(
-                $catalogPath . '/cache/' . $cacheId . '/' . $filePath
-            );
+            foreach ($files as $filePath) {
+                $this->mediaDirectory->delete(
+                    $catalogPath . '/cache/' . $cacheId . '/' . $filePath
+                );
+            }
         }
         return null;
     }