Skip to content

Commit 68a48d0

Browse files
author
Robert He
committed
MAGETWO-33109 : Refactor code that uses customer builders in Quote module
-- fixed static code failures
1 parent 4b892d0 commit 68a48d0

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

dev/tests/integration/testsuite/Magento/Customer/Api/AddressRepositoryTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,8 @@ public function searchAddressDataProvider()
388388
private function _createFirstAddress()
389389
{
390390
$address = $this->_addressFactory->create();
391-
$this->dataObjectHelper->mergeDataObjects('\Magento\Customer\Api\Data\AddressInterface',
391+
$this->dataObjectHelper->mergeDataObjects(
392+
'\Magento\Customer\Api\Data\AddressInterface',
392393
$address,
393394
$this->_expectedAddresses[0]
394395
);

dev/tests/unit/testsuite/Magento/Framework/Api/DataObjectHelperTest.php

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -261,10 +261,12 @@ public function testMergeDataObjects($data1, $data2)
261261

262262
$firstRegionDataObject->setRegionId($data1['region']['region_id']);
263263
$firstRegionDataObject->setRegion($data1['region']['region']);
264-
if(isset($data1['id']))
264+
if(isset($data1['id'])) {
265265
$firstAddressDataObject->setId($data1['id']);
266-
if(isset($data1['country_id']))
266+
}
267+
if(isset($data1['country_id'])) {
267268
$firstAddressDataObject->setCountryId($data1['country_id']);
269+
}
268270
$firstAddressDataObject->setStreet($data1['street']);
269271
$firstAddressDataObject->setIsDefaultShipping($data1['default_shipping']);
270272
$firstAddressDataObject->setRegion($firstRegionDataObject);
@@ -286,14 +288,16 @@ public function testMergeDataObjects($data1, $data2)
286288

287289
$secondRegionDataObject->setRegionId($data2['region']['region_id']);
288290
$secondRegionDataObject->setRegion($data2['region']['region']);
289-
if(isset($data2['id']))
291+
if(isset($data2['id'])) {
290292
$secondAddressDataObject->setId($data2['id']);
291-
if(isset($data2['country_id']))
293+
}
294+
if(isset($data2['country_id'])) {
292295
$secondAddressDataObject->setCountryId($data2['country_id']);
296+
}
293297
$secondAddressDataObject->setStreet($data2['street']);
294298
$secondAddressDataObject->setIsDefaultShipping($data2['default_shipping']);
295299
$secondAddressDataObject->setRegion($secondRegionDataObject);
296-
300+
297301
$this->objectProcessorMock->expects($this->once())
298302
->method('buildOutputDataArray')
299303
->with($secondAddressDataObject, get_class($firstAddressDataObject))
@@ -311,8 +315,11 @@ public function testMergeDataObjects($data1, $data2)
311315
->with('\Magento\Customer\Api\Data\RegionInterface', [])
312316
->willReturn($secondRegionDataObject);
313317

314-
$this->dataObjectHelper->mergeDataObjects(get_class($firstAddressDataObject), $firstAddressDataObject,
315-
$secondAddressDataObject);
318+
$this->dataObjectHelper->mergeDataObjects(
319+
get_class($firstAddressDataObject),
320+
$firstAddressDataObject,
321+
$secondAddressDataObject
322+
);
316323

317324
$this->assertSame($firstAddressDataObject->getId(), $secondAddressDataObject->getId());
318325
$this->assertSame($firstAddressDataObject->getCountryId(), $secondAddressDataObject->getCountryId());

0 commit comments

Comments
 (0)