Skip to content

Commit 689ed44

Browse files
author
Mike Weis
committed
MAGETWO-33664: Refactor Sales module to use mutable data object interfaces
- updated per code review comments
1 parent f708e44 commit 689ed44

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

app/code/Magento/Quote/Model/Quote/Payment/ToOrderPayment.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class ToOrderPayment
2323
protected $objectCopyService;
2424

2525
/**
26-
* @var OrderPaymentFactory|\Magento\Framework\Api\Builder
26+
* @var OrderPaymentFactory
2727
*/
2828
protected $orderPaymentFactory;
2929

@@ -74,8 +74,9 @@ public function convert(Payment $object, $data = [])
7474
)
7575
)
7676
);
77-
$orderPayment->setCcNumberEnc($object->getCcNumber());
78-
$orderPayment->setCcCidEnc($object->getCcCidEnc());
77+
// set directly on the model
78+
$orderPayment->setCcNumber($object->getCcNumber());
79+
$orderPayment->setCcCid($object->getCcCid());
7980

8081
return $orderPayment;
8182
}

dev/tests/integration/testsuite/Magento/Sales/Model/Order/AddressTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public function testSave()
3131
$this->_model->setEmail('co@co.co');
3232
$this->_model->setPostcode('12345');
3333
$this->_model->setLastname('LastName');
34-
$this->_model->setStreet(['Street']);
34+
$this->_model->setStreet('Street');
3535
$this->_model->setCity('City');
3636
$this->_model->setTelephone('123-45-67');
3737
$this->_model->setCountryId(1);

dev/tests/integration/testsuite/Magento/Sales/_files/address_data.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
'postcode' => '11111',
1010
'lastname' => 'lastname',
1111
'firstname' => 'firstname',
12-
'street' => ['street'],
12+
'street' => 'street',
1313
'city' => 'Los Angeles',
1414
'email' => 'admin@example.com',
1515
'telephone' => '11111111',

0 commit comments

Comments
 (0)