Skip to content

Commit 689812b

Browse files
author
Dimitri BOUTEILLE
committed
Fix bad phpdoc Magento\Framework\App\Config\ScopeConfigInterface
1 parent 7377de5 commit 689812b

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

app/code/Magento/Backend/Model/View/Result/Page.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function setActiveMenu($itemId)
3636
/**
3737
* Add link to breadcrumb block
3838
*
39-
* @param string $label
39+
* @param \Stringable $label
4040
* @param string $title
4141
* @param string|null $link
4242
* @return $this

lib/internal/Magento/Framework/App/Config.php

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,7 @@ public function __construct(
4545
}
4646

4747
/**
48-
* Retrieve config value by path and scope
49-
*
50-
* @param string $path
51-
* @param string $scope
52-
* @param null|int|string $scopeCode
53-
* @return mixed
48+
* @inheritDoc
5449
*/
5550
public function getValue(
5651
$path = null,
@@ -80,12 +75,7 @@ public function getValue(
8075
}
8176

8277
/**
83-
* Retrieve config flag
84-
*
85-
* @param string $path
86-
* @param string $scope
87-
* @param null|int|string $scopeCode
88-
* @return bool
78+
* @inheritDoc
8979
*/
9080
public function isSetFlag($path, $scope = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeCode = null)
9181
{

lib/internal/Magento/Framework/App/Config/ScopeConfigInterface.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ interface ScopeConfigInterface
2424
*
2525
* @param string $path The path through the tree of configuration values, e.g., 'general/store_information/name'
2626
* @param string $scopeType The scope to use to determine config value, e.g., 'store' or 'default'
27-
* @param null|int|string $scopeCode
27+
* @param null|int|string|\Magento\Store\Api\Data\StoreInterface $scopeCode
2828
* @return mixed
2929
*/
3030
public function getValue($path, $scopeType = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeCode = null);
@@ -34,7 +34,7 @@ public function getValue($path, $scopeType = ScopeConfigInterface::SCOPE_TYPE_DE
3434
*
3535
* @param string $path The path through the tree of configuration values, e.g., 'general/store_information/name'
3636
* @param string $scopeType The scope to use to determine config value, e.g., 'store' or 'default'
37-
* @param null|int|string $scopeCode
37+
* @param null|int|string|\Magento\Store\Api\Data\StoreInterface $scopeCode
3838
* @return bool
3939
*/
4040
public function isSetFlag($path, $scopeType = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeCode = null);

0 commit comments

Comments
 (0)