Skip to content

Commit 6872432

Browse files
author
Mike Weis
committed
MAGETWO-33664: Refactor Sales module to use mutable data object interfaces
- fixes per code review
1 parent a25f386 commit 6872432

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

app/code/Magento/Sales/Api/Data/OrderItemInterface.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -857,7 +857,7 @@ public function getProductOptions();
857857
* @param string[] $productOptions
858858
* @return $this
859859
*/
860-
public function setProductOptions($productOptions);
860+
public function setProductOptions(array $productOptions = null);
861861

862862
/**
863863
* Gets the product type for the order item.
@@ -1068,7 +1068,7 @@ public function getParentItem();
10681068
* @param \Magento\Sales\Api\Data\OrderItemInterface $parentItem
10691069
* @return $this
10701070
*/
1071-
public function setParentItem($parentItem);
1071+
public function setParentItem(\Magento\Sales\Api\Data\OrderItemInterface $parentItem);
10721072

10731073
/**
10741074
* Sets the updated-at timestamp for the order item.

app/code/Magento/Sales/Model/Order/Item.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,10 +150,10 @@ protected function _construct()
150150
/**
151151
* Set parent item
152152
*
153-
* @param Item $item
153+
* @param \Magento\Sales\Api\Data\OrderItemInterface $item
154154
* @return $this
155155
*/
156-
public function setParentItem($item)
156+
public function setParentItem(\Magento\Sales\Api\Data\OrderItemInterface $item)
157157
{
158158
if ($item) {
159159
$this->setData(OrderItemInterface::PARENT_ITEM, $item);
@@ -453,7 +453,7 @@ public function getOriginalPrice()
453453
* @param array $options
454454
* @return $this
455455
*/
456-
public function setProductOptions($options)
456+
public function setProductOptions(array $options = null)
457457
{
458458
$this->setData('product_options', $options);
459459
return $this;

0 commit comments

Comments
 (0)