MAGETWO-44975: Incorrect messgae on success page after extension installation

Igor Melnikov · Igor Melnikov · commit 67cbb987451d · 2015-11-04T20:43:35.000-06:00
Setting titles in state
diff --git a/setup/pub/magento/setup/component-grid.js b/setup/pub/magento/setup/component-grid.js
@@ -122,7 +122,7 @@ angular.module('component-grid', ['ngStorage'])
                 if ($localStorage.titles['update'].indexOf($localStorage.moduleName) < 0 ) {
                     $localStorage.titles['update'] = 'Update ' + $localStorage.moduleName;
                 }
-                $rootScope.titles = $localStorage.titles;
+                $state.titles = $localStorage.titles;
                 $scope.nextState();
             };
 
@@ -140,7 +140,7 @@ angular.module('component-grid', ['ngStorage'])
                 if ($localStorage.titles['uninstall'].indexOf($localStorage.moduleName) < 0 ) {
                     $localStorage.titles['uninstall'] = 'Uninstall ' + $localStorage.moduleName;
                 }
-                $rootScope.titles = $localStorage.titles;
+                $state.titles = $localStorage.titles;
                 $localStorage.componentType = component.type;
                 $state.go('root.readiness-check-uninstall');
             };
@@ -161,7 +161,7 @@ angular.module('component-grid', ['ngStorage'])
                         $localStorage.titles[type] = type.charAt(0).toUpperCase() + type.slice(1) + ' '
                             + $localStorage.moduleName;
                     }
-                    $rootScope.titles = $localStorage.titles;
+                    $state.titles = $localStorage.titles;
                     $localStorage.componentType = component.type;
                     $state.go('root.readiness-check-'+type);
                 }

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ angular.module('component-grid', ['ngStorage'])`
`122`	`122`	`if ($localStorage.titles['update'].indexOf($localStorage.moduleName) < 0 ) {`
`123`	`123`	`$localStorage.titles['update'] = 'Update ' + $localStorage.moduleName;`
`124`	`124`	`}`
`125`		`- $rootScope.titles = $localStorage.titles;`
	`125`	`+ $state.titles = $localStorage.titles;`
`126`	`126`	`$scope.nextState();`
`127`	`127`	`};`
`128`	`128`
`@@ -140,7 +140,7 @@ angular.module('component-grid', ['ngStorage'])`
`140`	`140`	`if ($localStorage.titles['uninstall'].indexOf($localStorage.moduleName) < 0 ) {`
`141`	`141`	`$localStorage.titles['uninstall'] = 'Uninstall ' + $localStorage.moduleName;`
`142`	`142`	`}`
`143`		`- $rootScope.titles = $localStorage.titles;`
	`143`	`+ $state.titles = $localStorage.titles;`
`144`	`144`	`$localStorage.componentType = component.type;`
`145`	`145`	`$state.go('root.readiness-check-uninstall');`
`146`	`146`	`};`
`@@ -161,7 +161,7 @@ angular.module('component-grid', ['ngStorage'])`
`161`	`161`	`$localStorage.titles[type] = type.charAt(0).toUpperCase() + type.slice(1) + ' '`
`162`	`162`	`+ $localStorage.moduleName;`
`163`	`163`	`}`
`164`		`- $rootScope.titles = $localStorage.titles;`
	`164`	`+ $state.titles = $localStorage.titles;`
`165`	`165`	`$localStorage.componentType = component.type;`
`166`	`166`	`$state.go('root.readiness-check-'+type);`
`167`	`167`	`}`