Skip to content

Commit 66eea55

Browse files
committed
GraphQL-594,595,600:fixed additional code review comments
for integration tests
1 parent 0e78cca commit 66eea55

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

dev/tests/integration/testsuite/Magento/Cms/_files/pages.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
->setContentHeading('<h2>Cms Page 100 Title</h2>')
1515
->setMetaTitle('Cms Meta title for page100')
1616
->setMetaKeywords('Cms Meta Keywords for page100')
17-
->setsetMetaDescription('Cms Meta Description for page100')
17+
->setMetaDescription('Cms Meta Description for page100')
1818
->setPageLayout('1column')
1919
->save();
2020

@@ -27,7 +27,7 @@
2727
->setContentHeading('<h2>Cms Page Blank Title</h2>')
2828
->setMetaTitle('Cms Meta title for Blank page')
2929
->setMetaKeywords('Cms Meta Keywords for Blank page')
30-
->setsetMetaDescription('Cms Meta Description for Blank page')
30+
->setMetaDescription('Cms Meta Description for Blank page')
3131
->setPageLayout('1column')
3232
->setCustomTheme('Magento/blank')
3333
->save();

dev/tests/integration/testsuite/Magento/GraphQlCache/Controller/Catalog/CategoriesWithProductsCacheTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
*
1919
* @magentoAppArea graphql
2020
* @magentoCache full_page enabled
21-
* @magentoDbIsolation disabled
2221
*/
2322
class CategoriesWithProductsCacheTest extends AbstractGraphqlCacheTest
2423
{
@@ -81,7 +80,7 @@ public function testToCheckRequestCacheTagsForCategoryWithProducts(): void
8180
}
8281
QUERY;
8382
$variables =[
84-
'id' => 333,
83+
'id' => $categoryId,
8584
'pageSize'=> 10,
8685
'currentPage' => 1
8786
];
@@ -105,3 +104,4 @@ public function testToCheckRequestCacheTagsForCategoryWithProducts(): void
105104
$this->assertEquals($expectedCacheTags, $actualCacheTags);
106105
}
107106
}
107+

dev/tests/integration/testsuite/Magento/GraphQlCache/Controller/Catalog/CategoryCacheTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,7 @@ public function testToCheckRequestCacheTagsForForCategory(): void
7171
$this->assertEquals('MISS', $response->getHeader('X-Magento-Cache-Debug')->getFieldValue());
7272
$actualCacheTags = explode(',', $response->getHeader('X-Magento-Tags')->getFieldValue());
7373
$expectedCacheTags = ['cat_c','cat_c_' . $categoryId,'FPC'];
74-
foreach (array_keys($actualCacheTags) as $key) {
75-
$this->assertEquals($expectedCacheTags[$key], $actualCacheTags[$key]);
76-
}
74+
$this->assertEquals($expectedCacheTags, $actualCacheTags);
7775
}
7876
}
77+

dev/tests/integration/testsuite/Magento/GraphQlCache/Controller/Catalog/ProductsCacheTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
*
1818
* @magentoAppArea graphql
1919
* @magentoCache full_page enabled
20-
* @magentoDbIsolation disabled
2120
*/
2221
class ProductsCacheTest extends AbstractGraphqlCacheTest
2322
{
@@ -85,3 +84,4 @@ public function testToCheckRequestCacheTagsForProducts(): void
8584
$this->assertEquals($expectedCacheTags, $actualCacheTags);
8685
}
8786
}
87+

0 commit comments

Comments
 (0)