Skip to content

Commit 667d5f0

Browse files
committed
MC-10263: Verify Shopping Cart Persistence under long-term cookie
1 parent b379aa4 commit 667d5f0

File tree

7 files changed

+27
-16
lines changed

7 files changed

+27
-16
lines changed

app/code/Magento/Checkout/Test/Mftf/Section/CheckoutCartProductSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,6 @@
3535
<element name="productPriceByName" type="text"
3636
selector="//table[@id='shopping-cart-table']//tbody//tr[//a/text()='{{var1}}']//ancestor::td[contains(@class,'price')]//span[@class='price']"
3737
parameterized="true"/>
38-
<element name="productName" type="text" selector="//tbody[@class='cart item']//strong[@class='product-item-name']"/>
38+
<element name="productName" type="text" selector="#shopping-cart-table .product-item-details > strong"/>
3939
</section>
4040
</sections>

app/code/Magento/Customer/Test/Mftf/ActionGroup/AdminDeleteCustomerActionGroup.xml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,16 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="AdminDeleteCustomerActionGroup">
1111
<arguments>
12-
<argument name="customerEmail"/>
12+
<argument name="customerEmail" type="string"/>
1313
</arguments>
1414
<amOnPage url="{{AdminCustomerPage.url}}" stepKey="navigateToCustomersPage"/>
1515
<conditionalClick selector="{{AdminCustomerFiltersSection.clearFilters}}" dependentSelector="{{AdminCustomerFiltersSection.clearFilters}}" visible="true" stepKey="clickClearFilters"/>
16-
<click selector="{{AdminCustomerGridMainActionsSection.customerCheckbox(customerEmail)}}" stepKey="chooseCustomer"/>
17-
<click selector="{{AdminCustomerGridMainActionsSection.actions}}" stepKey="openActions"/>
18-
<waitForPageLoad stepKey="waitActions"/>
19-
<click selector="{{AdminCustomerGridMainActionsSection.delete}}" stepKey="delete"/>
20-
<waitForPageLoad stepKey="waitForConfirmationAlert"/>
16+
<click selector="{{AdminGridActionsMenuSection.checkbox(customerEmail)}}" stepKey="chooseCustomer"/>
17+
<click selector="{{AdminGridActionsMenuSection.actions}}" stepKey="openActions"/>
18+
<click selector="{{AdminGridActionsMenuSection.delete}}" stepKey="delete"/>
19+
<waitForElementVisible selector="{{AdminConfirmationModalSection.ok}}" stepKey="waitForElementVisible"/>
2120
<click selector="{{AdminConfirmationModalSection.ok}}" stepKey="accept"/>
22-
<see selector="{{AdminMessagesSection.successMessage}}" userInput="were deleted." stepKey="seeSuccessMessage"/>
21+
<waitForElementVisible selector="{{AdminMessagesSection.successMessage}}" stepKey="waitForSuccessMessage"/>
22+
<see selector="{{AdminMessagesSection.successMessage}}" userInput="were deleted." stepKey="seeSuccessMessage"/>
2323
</actionGroup>
2424
</actionGroups>

app/code/Magento/Customer/Test/Mftf/ActionGroup/StorefrontAssertMessageCustomerCreateAccountActionGroup.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
<actionGroup name="StorefrontAssertMessageCustomerCreateAccountActionGroup">
1212
<arguments>
1313
<argument name="message" type="string" defaultValue="Thank you for registering with Main Website Store." />
14-
<argument name="messageType" type="string" defaultValue="success" />
1514
</arguments>
16-
<see selector="{{StorefrontCustomerDashboardAccountInformationSection.messageByType(messageType)}}" userInput="{{message}}" stepKey="verifyMessage" />
15+
<see selector="{{StorefrontMessagesSection.successMessage}}" userInput="{{message}}" stepKey="verifyMessage" />
1716
</actionGroup>
1817
</actionGroups>

app/code/Magento/Customer/Test/Mftf/Section/AdminCustomerGridMainActionsSection.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,5 @@
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1111
<section name="AdminCustomerGridMainActionsSection">
1212
<element name="addNewCustomer" type="button" selector="#add" timeout="30"/>
13-
<element name="delete" type="button" selector="//*[contains(@class, 'admin__data-grid-header')]//span[contains(@class,'action-menu-item') and text()='Delete']"/>
14-
<element name="actions" type="text" selector=".action-select"/>
15-
<element name="customerCheckbox" type="button" selector="//*[contains(text(),'{{customerEmail}}')]/parent::td/preceding-sibling::td/label[@class='data-grid-checkbox-cell-inner']//input" parameterized="true"/>
1613
</section>
1714
</sections>

app/code/Magento/Customer/Test/Mftf/Section/StorefrontCustomerDashboardAccountInformationSection.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,5 @@
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1111
<section name="StorefrontCustomerDashboardAccountInformationSection">
1212
<element name="ContactInformation" type="textarea" selector=".box.box-information .box-content"/>
13-
<element name="messageByType" type="block" selector="#maincontent .message-{{messageType}}" parameterized="true" />
1413
</section>
1514
</sections>

app/code/Magento/Persistent/Test/Mftf/Test/StorefrontVerifyShoppingCartPersistenceUnderLongTermCookieTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@
4040
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
4141
<actionGroup ref="LoginAsAdmin" stepKey="LoginAsAdmin"/>
4242
<actionGroup ref="AdminDeleteCustomerActionGroup" stepKey="deleteJohnSmithCustomer">
43-
<argument name="customerEmail" value="John_Smith_Customer.email"/>
43+
<argument name="customerEmail" value="{{John_Smith_Customer.email}}"/>
4444
</actionGroup>
4545
<actionGroup ref="AdminDeleteCustomerActionGroup" stepKey="deleteJohnDoeCustomer">
46-
<argument name="customerEmail" value="Simple_Customer_Without_Address.email"/>
46+
<argument name="customerEmail" value="{{Simple_Customer_Without_Address.email}}"/>
4747
</actionGroup>
4848
<actionGroup ref="logout" stepKey="logout"/>
4949
</after>
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
11+
<section name="AdminGridActionsMenuSection">
12+
<element name="delete" type="button" selector="//*[contains(@class, 'row-gutter')]//span[contains(@class,'action-menu-item') and text()='Delete']" timeout="30"/>
13+
<element name="actions" type="text" selector=".row-gutter .action-select" timeout="30"/>
14+
<element name="checkbox" type="checkbox" selector="//*[contains(text(),'{{columnValue}}')]/parent::td/preceding-sibling::td/label[@class='data-grid-checkbox-cell-inner']//input" parameterized="true"/>
15+
</section>
16+
</sections>

0 commit comments

Comments
 (0)