Skip to content

Commit 6673030

Browse files
Raj MohanRaj Mohan
authored andcommitted
Merge remote-tracking branch 'origin/AC-12092_PHPUnit10' into AC-12092_PHPUnit10
2 parents 13d3e59 + c3b7947 commit 6673030

File tree

8 files changed

+5
-54
lines changed

8 files changed

+5
-54
lines changed

app/code/Magento/ConfigurableProduct/Test/Unit/Model/Product/Type/VariationMatrixTest.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ public function testGetVariations($expectedResult)
4545
public static function variationProvider()
4646
{
4747
return [
48-
'with_attribute_id' => [
49-
'expectedResult' => [
48+
[
49+
[
5050
'result' => [
5151
[
5252
130 => [
@@ -101,10 +101,8 @@ public static function variationProvider()
101101
],
102102
],
103103
]
104-
]
105-
],
106-
'without_attribute_id' => [
107-
'expectedResult' => [
104+
],
105+
[
108106
'result' => [
109107
[
110108
130 => [

app/code/Magento/Csp/Test/Unit/Plugin/StoreAssetIntegrityHashesTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ protected function setUp(): void
6262
* Test After Deploy method of plugin
6363
*
6464
* @return void
65-
* @doesNotPerformAssertions
6665
*/
6766
public function testAfterDeploy(): void
6867
{

app/code/Magento/Customer/Test/Unit/Model/AccountManagementApiTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -433,8 +433,6 @@ public function testBeforeCreateAccount(
433433
): void {
434434
if ($willThrowException) {
435435
$this->expectException(AuthorizationException::class);
436-
} else {
437-
$this->expectNotToPerformAssertions();
438436
}
439437
$this->authorizationMock
440438
->expects($this->once())

app/code/Magento/Customer/Test/Unit/Plugin/AsyncRequestCustomerGroupAuthorizationTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ public function testBeforePublishMass(
7575
): void {
7676
if ($willThrowException) {
7777
$this->expectException(AuthorizationException::class);
78-
} else {
79-
$this->expectNotToPerformAssertions();
8078
}
8179
$customer = $this->getMockForAbstractClass(CustomerInterface::class);
8280
$customer->method('getGroupId')->willReturn($groupId);

app/code/Magento/Swagger/Test/Unit/Controller/Index/IndexTest.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,6 @@ protected function setUp(): void
6666
);
6767
}
6868

69-
/**
70-
* @doesNotPerformAssertions
71-
*/
7269
public function testExecute()
7370
{
7471
$this->pageConfigMock->expects($this->once())
@@ -94,9 +91,6 @@ public function testDispatchRejectsWhenDisabled()
9491
$this->indexAction->dispatch($request);
9592
}
9693

97-
/**
98-
* @doesNotPerformAssertions
99-
*/
10094
public function testDispatchIsSuccessfulWhenEnabled()
10195
{
10296
$request = self::getMockBuilder(Http::class)

lib/internal/Magento/Framework/Webapi/Test/Unit/InputLimit/DefaultPageSizeSetterTest.php

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@ protected function setUp(): void
3737
$this->setter = new DefaultPageSizeSetter($this->configProvider);
3838
}
3939

40-
/**
41-
* @doesNotPerformAssertions
42-
*/
4340
public function testPageSizeIsNotSetWhenLimitingIsDisabled()
4441
{
4542
$this->configProvider->method('isInputLimitingEnabled')
@@ -54,9 +51,6 @@ public function testPageSizeIsNotSetWhenLimitingIsDisabled()
5451
$this->setter->processSearchCriteria($searchCriteria);
5552
}
5653

57-
/**
58-
* @doesNotPerformAssertions
59-
*/
6054
public function testPageSizeIsNotSetWhenAlreadySet()
6155
{
6256
$this->configProvider->method('isInputLimitingEnabled')
@@ -71,9 +65,6 @@ public function testPageSizeIsNotSetWhenAlreadySet()
7165
$this->setter->processSearchCriteria($searchCriteria);
7266
}
7367

74-
/**
75-
* @doesNotPerformAssertions
76-
*/
7768
public function testPageSizeIsSetWithPreferredConfigValue()
7869
{
7970
$this->configProvider->method('isInputLimitingEnabled')
@@ -92,9 +83,6 @@ public function testPageSizeIsSetWithPreferredConfigValue()
9283
$this->setter->processSearchCriteria($searchCriteria, 678);
9384
}
9485

95-
/**
96-
* @doesNotPerformAssertions
97-
*/
9886
public function testPageSizeIsSetWithPreferredFallbackValue()
9987
{
10088
$this->configProvider->method('isInputLimitingEnabled')

lib/internal/Magento/Framework/Webapi/Test/Unit/ServiceInputProcessorTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -414,9 +414,6 @@ public function testArrayOfDataObjectPropertiesIsValidated()
414414
);
415415
}
416416

417-
/**
418-
* @doesNotPerformAssertions
419-
*/
420417
public function testDefaultPageSizeSetterIsInvoked()
421418
{
422419
$this->defaultPageSizeSetter->expects(self::once())

lib/internal/Magento/Framework/Webapi/Test/Unit/Validator/EntityArrayValidatorTest.php

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,7 @@ protected function setUp(): void
4848
$this->inputArraySizeLimitValueMock
4949
);
5050
}
51-
52-
/**
53-
* @doesNotPerformAssertions
54-
*/
51+
5552
public function testAllowsDataWhenBelowLimitWhenUsingRouteInputLimit()
5653
{
5754
$this->configMock->expects(self::once())
@@ -65,9 +62,6 @@ public function testAllowsDataWhenBelowLimitWhenUsingRouteInputLimit()
6562
$this->validator->validateComplexArrayType("foo", array_fill(0, 5, []));
6663
}
6764

68-
/**
69-
* @doesNotPerformAssertions
70-
*/
7165
public function testFailsDataWhenAboveLimitUsingRouteInputLimit()
7266
{
7367
$this->expectException(InvalidArgumentException::class);
@@ -83,9 +77,6 @@ public function testFailsDataWhenAboveLimitUsingRouteInputLimit()
8377
$this->validator->validateComplexArrayType("foo", array_fill(0, 5, []));
8478
}
8579

86-
/**
87-
* @doesNotPerformAssertions
88-
*/
8980
public function testAllowsDataWhenBelowLimit()
9081
{
9182
$this->configMock->expects(self::once())
@@ -100,9 +91,6 @@ public function testAllowsDataWhenBelowLimit()
10091
$this->validator->validateComplexArrayType("foo", array_fill(0, 3, []));
10192
}
10293

103-
/**
104-
* @doesNotPerformAssertions
105-
*/
10694
public function testAllowsDataWhenBelowLimitUsingConfig()
10795
{
10896
$this->configMock->expects(self::once())
@@ -117,9 +105,6 @@ public function testAllowsDataWhenBelowLimitUsingConfig()
117105
$this->validator->validateComplexArrayType("foo", array_fill(0, 5, []));
118106
}
119107

120-
/**
121-
* @doesNotPerformAssertions
122-
*/
123108
public function testFailsDataWhenAboveLimit()
124109
{
125110
$this->expectException(InvalidArgumentException::class);
@@ -136,9 +121,6 @@ public function testFailsDataWhenAboveLimit()
136121
$this->validator->validateComplexArrayType("foo", array_fill(0, 4, []));
137122
}
138123

139-
/**
140-
* @doesNotPerformAssertions
141-
*/
142124
public function testFailsDataWhenAboveLimitUsingConfig()
143125
{
144126
$this->expectException(InvalidArgumentException::class);
@@ -155,9 +137,6 @@ public function testFailsDataWhenAboveLimitUsingConfig()
155137
$this->validator->validateComplexArrayType("foo", array_fill(0, 7, []));
156138
}
157139

158-
/**
159-
* @doesNotPerformAssertions
160-
*/
161140
public function testAboveLimitWithDisabledLimiting()
162141
{
163142
$this->configMock->expects(self::once())

0 commit comments

Comments
 (0)