CE-33707: Fixed missed files

Author: bohdan-harniuk

app/code/Magento/Wishlist/Test/Unit/Controller/Index/UpdateItemOptionsTest.php

@@ -99,9 +99,7 @@ class UpdateItemOptionsTest extends TestCase
     protected $formKeyValidator;
 
     /**
-     * SetUp method
-     *
-     * @return void
+     * @inheritDoc
      */
     protected function setUp(): void
     {
@@ -132,9 +130,7 @@ protected function setUp(): void
     }
 
     /**
-     * TearDown method
-     *
-     * @return void
+     * @inheritDoc
      */
     protected function tearDown(): void
     {
@@ -155,7 +151,7 @@ protected function tearDown(): void
      *
      * @return void
      */
-    public function prepareContext()
+    public function prepareContext(): void
     {
         $actionFlag = $this->createMock(ActionFlag::class);
 
@@ -211,7 +207,10 @@ protected function getController()
         );
     }
 
-    public function testExecuteWithInvalidFormKey()
+    /**
+     * @return void
+     */
+    public function testExecuteWithInvalidFormKey(): void
     {
         $this->prepareContext();
 
@@ -235,11 +234,11 @@ public function testExecuteWithInvalidFormKey()
     }
 
     /**
-     * Test execute without product id
+     * Test execute without product id.
      *
      * @return void
      */
-    public function testExecuteWithoutProductId()
+    public function testExecuteWithoutProductId(): void
     {
         $this->request
             ->expects($this->once())
@@ -255,11 +254,11 @@ public function testExecuteWithoutProductId()
     }
 
     /**
-     * Test execute without product
+     * Test execute without product.
      *
      * @return void
      */
-    public function testExecuteWithoutProduct()
+    public function testExecuteWithoutProduct(): void
     {
         $this->request
             ->expects($this->once())
@@ -287,11 +286,11 @@ public function testExecuteWithoutProduct()
     }
 
     /**
-     * Test execute without wish list
+     * Test execute without wish list.
      *
      * @return void
      */
-    public function testExecuteWithoutWishList()
+    public function testExecuteWithoutWishList(): void
     {
         $product = $this->createMock(Product::class);
         $item = $this->createMock(Item::class);
@@ -302,15 +301,9 @@ public function testExecuteWithoutWishList()
             ->willReturn(true);
 
         $this->request
-            ->expects($this->at(0))
             ->method('getParam')
-            ->with('product', null)
-            ->willReturn(2);
-        $this->request
-            ->expects($this->at(1))
-            ->method('getParam')
-            ->with('id', null)
-            ->willReturn(3);
+            ->withConsecutive(['product', null], ['id', null])
+            ->willReturnOnConsecutiveCalls(2, 3);
 
         $this->productRepository
             ->expects($this->once())
@@ -355,12 +348,12 @@ public function testExecuteWithoutWishList()
     }
 
     /**
-     * Test execute add success exception
+     * Test execute add success exception.
      *
      * @return void
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
-    public function testExecuteAddSuccessException()
+    public function testExecuteAddSuccessException(): void
     {
         $wishlist = $this->createMock(Wishlist::class);
         $product = $this->createMock(Product::class);
@@ -401,15 +394,9 @@ public function testExecuteAddSuccessException()
             ->willReturn('Test name');
 
         $this->request
-            ->expects($this->at(0))
-            ->method('getParam')
-            ->with('product', null)
-            ->willReturn(2);
-        $this->request
-            ->expects($this->at(1))
             ->method('getParam')
-            ->with('id', null)
-            ->willReturn(3);
+            ->withConsecutive(['product', null], ['id', null])
+            ->willReturnOnConsecutiveCalls(2, 3);
 
         $this->productRepository
             ->expects($this->once())
@@ -476,12 +463,12 @@ public function testExecuteAddSuccessException()
     }
 
     /**
-     * Test execute add success critical exception
+     * Test execute add success critical exception.
      *
      * @return void
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
-    public function testExecuteAddSuccessCriticalException()
+    public function testExecuteAddSuccessCriticalException(): void
     {
         $wishlist = $this->createMock(Wishlist::class);
         $product = $this->createMock(Product::class);
@@ -493,8 +480,7 @@ public function testExecuteAddSuccessCriticalException()
         $logger
             ->expects($this->once())
             ->method('critical')
-            ->with($exception)
-            ->willReturn(true);
+            ->with($exception);
 
         $helper
             ->expects($this->exactly(2))
@@ -530,15 +516,9 @@ public function testExecuteAddSuccessCriticalException()
             ->willReturn('Test name');
 
         $this->request
-            ->expects($this->at(0))
-            ->method('getParam')
-            ->with('product', null)
-            ->willReturn(2);
-        $this->request
-            ->expects($this->at(1))
             ->method('getParam')
-            ->with('id', null)
-            ->willReturn(3);
+            ->withConsecutive(['product', null], ['id', null])
+            ->willReturnOnConsecutiveCalls(2, 3);
 
         $this->productRepository
             ->expects($this->once())
@@ -575,20 +555,9 @@ public function testExecuteAddSuccessCriticalException()
             ->willReturn([]);
 
         $this->om
-            ->expects($this->at(1))
-            ->method('get')
-            ->with(Data::class)
-            ->willReturn($helper);
-        $this->om
-            ->expects($this->at(2))
-            ->method('get')
-            ->with(Data::class)
-            ->willReturn($helper);
-        $this->om
-            ->expects($this->at(3))
             ->method('get')
-            ->with(LoggerInterface::class)
-            ->willReturn($logger);
+            ->withConsecutive([Data::class], [Data::class], [LoggerInterface::class])
+            ->willReturnOnConsecutiveCalls($helper, $helper, $logger);
 
         $this->eventManager
             ->expects($this->once())