MAGETWO-85063: Create a framework for dynamically composing what's new content

Author: rossbrandon

app/code/Magento/Analytics/Model/ReportXml/ModuleIterator.php

@@ -8,7 +8,7 @@
 use Magento\Framework\Module\Manager as ModuleManager;
 
 /**
- * Factory to create a module iterator
+ * Iterator for ReportXml modules
  */
 class ModuleIterator extends \IteratorIterator
 {

app/code/Magento/ReleaseNotification/Model/ContentProvider/Http/HttpContentProvider.php

@@ -66,7 +66,7 @@ public function getContent($version, $edition, $locale)
             $this->logger->warning(
                 sprintf(
                     'Failed to retrieve the release notification content. The response is: %s',
-                    !empty($result) ? $result : 'Response body is empty.'
+                    empty($result) ? 'Response body is empty.' : $result
                 )
             );
         }

app/code/Magento/ReleaseNotification/Model/ContentProviderInterface.php

@@ -14,8 +14,6 @@ interface ContentProviderInterface
     /**
      * Retrieves the release notification content data.
      *
-     * Returns received content or FALSE in case of failure.
-     *
      * @param string $version
      * @param string $edition
      * @param string $locale

app/code/Magento/ReleaseNotification/Test/Unit/Model/ContentProvider/Http/HttpContentProviderTest.php

@@ -112,7 +112,7 @@ public function testGetContentSuccessOnLocaleDefault()
         $edition = 'Community';
         $locale = 'fr_FR';
         $urlLocale = 'https://content.url.example/'. $version . '/' . $edition . '/' . $locale . '.json';
-        $urlDefaultLocale = 'https://content.url.example/2.3.0/'. $version . '/' . $edition . '/en_US.json';
+        $urlDefaultLocale = 'https://content.url.example/'. $version . '/' . $edition . '/en_US.json';
         $response = '{"return":"default-locale"}';
 
         $this->urlBuilderMock->expects($this->exactly(2))
@@ -147,7 +147,7 @@ public function testGetContentSuccessOnLocaleDefault()
     public function testGetContentSuccessOnDefaultOrEmpty($version, $edition, $locale, $response)
     {
         $urlLocale = 'https://content.url.example/'. $version . '/' . $edition . '/' . $locale . '.json';
-        $urlDefaultLocale = 'https://content.url.example/2.3.0/'. $version . '/' . $edition . '/en_US.json';
+        $urlDefaultLocale = 'https://content.url.example/'. $version . '/' . $edition . '/en_US.json';
         $urlDefault = 'https://content.url.example/' . $version . '/default.json';
 
         $this->urlBuilderMock->expects($this->exactly(3))