Skip to content

Commit 659c737

Browse files
authored
Merge pull request #2329 from magento-panda/2.3-PR
Fixed issues: - MAGETWO-88028 Table is full errors on same modify profile - MAGETWO-89417 [2.3.x][Functional-Tests] - AdminSwitchWYSIWYGOptionsCest fails on 2.3-develop
2 parents d76b6c1 + 71bffdb commit 659c737

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

app/code/Magento/Catalog/Test/Unit/Model/ResourceModel/Product/Indexer/Price/IndexTableRowSizeEstimatorTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ protected function setUp()
3838

3939
public function testEstimateRowSize()
4040
{
41-
$this->markTestSkipped('Unskip after MAGETWO-89738');
42-
$expectedValue = 2400000;
41+
$expectedValue = 4000000;
4342

4443
$this->websiteManagementMock->expects($this->once())->method('getCount')->willReturn(100);
4544
$collectionMock = $this->createMock(\Magento\Customer\Model\ResourceModel\Group\Collection::class);

dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Cms/Test/AdminSwitchWYSIWYGOptionsCest.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
<title value="Admin are able to switch between versions of TinyMCE."/>
1717
<description value="Admin are able to switch between versions of TinyMCE."/>
1818
<severity value="CRITICAL"/>
19-
<group value="skip"/>
20-
<!-- Skipped; see MAGETWO-89417 -->
2119
<testCaseId value="MAGETWO-82936"/>
2220
<!--Skip because of issue MAGETWO-89417-->
2321
<group value="skip"/>
@@ -27,6 +25,7 @@
2725
<actionGroup ref="EnabledWYSIWYG" stepKey="enableWYSIWYG"/>
2826
</before>
2927
<amOnPage url="{{ConfigurationStoresPage.url}}" stepKey="navigateToWYSIWYGConfigPage1"/>
28+
<waitForPageLoad stepKey="wait1"/>
3029
<conditionalClick stepKey="expandWYSIWYGOptions1" selector="{{ContentManagementSection.WYSIWYGOptions}}" dependentSelector="{{ContentManagementSection.CheckIfTabExpand}}" visible="true" />
3130
<waitForElementVisible selector="{{ContentManagementSection.SwitcherSystemValue}}" stepKey="waitForCheckbox1" />
3231
<uncheckOption selector="{{ContentManagementSection.SwitcherSystemValue}}" stepKey="uncheckUseSystemValue1"/>
@@ -35,7 +34,7 @@
3534
<click selector="{{ContentManagementSection.WYSIWYGOptions}}" stepKey="collapseWYSIWYGOptions1" />
3635
<click selector="{{ContentManagementSection.Save}}" stepKey="clickSaveConfig1" />
3736
<amOnPage url="{{CmsNewPagePage.url}}" stepKey="navigateToPage1"/>
38-
<waitForPageLoad stepKey="wait1"/>
37+
<waitForPageLoad stepKey="wait2"/>
3938
<fillField selector="{{CmsNewPagePageBasicFieldsSection.pageTitle}}" userInput="{{_defaultCmsPage.title}}" stepKey="fillFieldTitle1"/>
4039
<click selector="{{CmsNewPagePageContentSection.header}}" stepKey="clickContentTab1" />
4140
<waitForElementVisible selector="{{TinyMCESection.TinyMCE4}}" stepKey="waitForTinyMCE4"/>
@@ -54,6 +53,7 @@
5453
<!--see widget on Storefront-->
5554
<see userInput="Hello TinyMCE4!" stepKey="seeContent1"/>
5655
<amOnPage url="{{ConfigurationStoresPage.url}}" stepKey="navigateToWYSIWYGConfigPage2"/>
56+
<waitForPageLoad stepKey="wait4"/>
5757
<conditionalClick stepKey="expandWYSIWYGOptions" selector="{{ContentManagementSection.WYSIWYGOptions}}" dependentSelector="{{ContentManagementSection.CheckIfTabExpand}}" visible="true" />
5858
<waitForElementVisible selector="{{ContentManagementSection.SwitcherSystemValue}}" stepKey="waitForCheckbox2" />
5959
<uncheckOption selector="{{ContentManagementSection.SwitcherSystemValue}}" stepKey="uncheckUseSystemValue2"/>
@@ -62,7 +62,7 @@
6262
<click selector="{{ContentManagementSection.WYSIWYGOptions}}" stepKey="collapseWYSIWYGOptions2" />
6363
<click selector="{{ContentManagementSection.Save}}" stepKey="clickSaveConfig2" />
6464
<amOnPage url="{{CmsNewPagePage.url}}" stepKey="navigateToPage2"/>
65-
<waitForPageLoad stepKey="wait2"/>
65+
<waitForPageLoad stepKey="wait5"/>
6666
<fillField selector="{{CmsNewPagePageBasicFieldsSection.pageTitle}}" userInput="{{_defaultCmsPage.title}}" stepKey="fillFieldTitle2"/>
6767
<click selector="{{CmsNewPagePageContentSection.header}}" stepKey="clickContentTab2" />
6868
<waitForElementVisible selector="{{TinyMCESection.TinyMCE3}}" stepKey="waitForTinyMCE3"/>
@@ -77,7 +77,7 @@
7777
<click selector="{{CmsNewPagePageActionsSection.savePage}}" stepKey="clickSavePage2"/>
7878
<!-- Go to storefront cms page, assert cms content -->
7979
<amOnPage url="{{simpleCmsPage.identifier}}" stepKey="amOnPageTestPage2"/>
80-
<waitForPageLoad stepKey="wait4" />
80+
<waitForPageLoad stepKey="wait6" />
8181
<!--see widget on Storefront-->
8282
<see userInput="Hello TinyMCE3!" stepKey="seeContent2"/>
8383
<actionGroup ref="SwitchToVersion4ActionGroup" stepKey="switchToTinyMCE4" />

0 commit comments

Comments
 (0)