magento/adobe-stock-integration#1391: SaveAssetsKeywordsInterface to delete obsolete keywords - integration test refactor

Author: jmonteros422

dev/tests/integration/testsuite/Magento/MediaGallery/Model/ResourceModel/AssetKeywordsTest.php

@@ -66,74 +66,57 @@ protected function setUp(): void
      *
      * @magentoDataFixture Magento/MediaGallery/_files/media_asset.php
      * @dataProvider keywordsProvider
-     * @param array $keywords
+     * @param array|null $keywords
+     * @param array|null $updatedKeywords
      * @throws \Magento\Framework\Exception\LocalizedException
      */
-    public function testSaveAndGetKeywords(array $keywords): void
+    public function testSaveAndGetKeywords(array $keywords = [], array $updatedKeywords = []): void
     {
-        $keywords = ['pear', 'plum'];
-        $updatedKeywords = ['pear', 'apple','orange'];
-
         $loadedAssets = $this->getAssetsByPath->execute([self::FIXTURE_ASSET_PATH]);
         $this->assertCount(1, $loadedAssets);
         $loadedAsset = current($loadedAssets);
 
+        $this->updateAssetKeywords($loadedAsset->getId(), $keywords);
+        $this->updateAssetKeywords($loadedAsset->getId(), $updatedKeywords);
+    }
+
+    /**
+     * Update Asset keywords
+     *
+     * @param int $assetId
+     * @param array|null $keywords
+     */
+    private function updateAssetKeywords(int $assetId, array $keywords = []): void
+    {
         $assetKeywords = $this->assetsKeywordsFactory->create(
             [
-                'assetId' => $loadedAsset->getId(),
+                'assetId' => $assetId,
                 'keywords' => $this->getKeywords($keywords)
             ]
         );
 
         $this->saveAssetsKeywords->execute([$assetKeywords]);
-        $loadedAssetKeywords = $this->getAssetsKeywords->execute([$loadedAsset->getId()]);
-
-        $this->assertCount(1, $loadedAssetKeywords);
-
-        /** @var AssetKeywordsInterface $loadedAssetKeyword */
-        $loadedAssetKeyword = current($loadedAssetKeywords);
-
-        $loadedKeywords = $loadedAssetKeyword->getKeywords();
+        $loadedAssetKeywords = $this->getAssetsKeywords->execute([$assetId]);
 
-        $this->assertEquals(count($keywords), count($loadedKeywords));
+        if (!empty($keywords)) {
+            $this->assertCount(1, $loadedAssetKeywords);
+            /** @var AssetKeywordsInterface $loadedAssetKeyword */
+            $loadedAssetKeyword = current($loadedAssetKeywords);
 
-        $loadedKeywordStrings = [];
-        foreach ($loadedKeywords as $loadedKeywordObject) {
-            $loadedKeywordStrings[] = $loadedKeywordObject->getKeyword();
-        }
-
-        sort($loadedKeywordStrings);
-        sort($keywords);
-
-        $this->assertEquals($keywords, $loadedKeywordStrings);
-
-        $updatedAssetKeywords = $this->assetsKeywordsFactory->create(
-            [
-                'assetId' => $loadedAsset->getId(),
-                'keywords' => $this->getKeywords($updatedKeywords)
-            ]
-        );
-        $this->saveAssetsKeywords->execute([$updatedAssetKeywords]);
-        $updatedLoadedAssetKeywords = $this->getAssetsKeywords->execute([$loadedAsset->getId()]);
-
-        $this->assertCount(1, $updatedLoadedAssetKeywords);
+            $loadedKeywords = $loadedAssetKeyword->getKeywords();
 
-        /** @var AssetKeywordsInterface $updatedLoadedAssetKeywords */
-        $updatedLoadedAssetKeywords = current($updatedLoadedAssetKeywords);
+            $this->assertEquals(count($keywords), count($loadedKeywords));
 
-        $updatedLoadedKeywords = $updatedLoadedAssetKeywords->getKeywords();
+            $loadedKeywordStrings = [];
+            foreach ($loadedKeywords as $loadedKeywordObject) {
+                $loadedKeywordStrings[] = $loadedKeywordObject->getKeyword();
+            }
 
-        $this->assertEquals(count($updatedKeywords), count($updatedLoadedKeywords));
+            sort($loadedKeywordStrings);
+            sort($keywords);
 
-        $updatedLoadedKeywordStrings = [];
-        foreach ($updatedLoadedKeywords as $updatedLoadedKeywordObject) {
-            $updatedLoadedKeywordStrings[] = $updatedLoadedKeywordObject->getKeyword();
+            $this->assertEquals($keywords, $loadedKeywordStrings);
         }
-
-        sort($updatedLoadedKeywordStrings);
-        sort($updatedKeywords);
-
-        $this->assertEquals($updatedKeywords, $updatedLoadedKeywordStrings);
     }
 
     /**
@@ -144,10 +127,17 @@ public function testSaveAndGetKeywords(array $keywords): void
     public function keywordsProvider(): array
     {
         return [
-            [['one-keyword']],
-            [['кириллица']],
-            [['plum', 'pear']],
-            [[]]
+            [['one-keyword'],['plum','orange']],
+            [['кириллица'],[]],
+            [[],['plum']],
+            [['plum', 'pear'],['plum','pear']],
+            [['plum', 'pear'],['plum','orange']],
+            [['plum', 'pear','grape'],['plum','orange']],
+            [['plum', 'pear','grape'],['mango']],
+            [['plum', 'pear','grape'],['orange']],
+            [['plum', 'pear','grape'],[]],
+            [['plum', 'pear'],['plum', 'pear','grape','mango','orange']],
+            [[],[]]
         ];
     }