Skip to content

Commit 656f2b0

Browse files
committed
229: [GraphQL caching] Add support for queries via HTTP GET
- fix web-api tests
1 parent 5ac9d3b commit 656f2b0

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

dev/tests/api-functional/framework/Magento/TestFramework/TestCase/GraphQl/Client.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,10 @@ public function get(string $query, array $variables = [], string $operationName
8181
$url = $this->getEndpointUrl();
8282
$requestArray = [
8383
'query' => $query,
84-
'variables' => empty($variables) ? $variables : null,
85-
'operationName' => empty($operationName) ? $operationName : null
84+
'variables' => $variables ? $this->json->jsonEncode($variables) : null,
85+
'operationName' => $operationName ?? null
8686
];
87+
array_filter($requestArray);
8788

8889
$responseBody = $this->curlClient->get($url, $requestArray, $headers);
8990
return $this->processResponse($responseBody);

dev/tests/api-functional/testsuite/Magento/GraphQl/Framework/QueryComplexityLimiterTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,8 @@ public function testQueryComplexityIsLimited()
393393
QUERY;
394394

395395
self::expectExceptionMessageRegExp('/Max query complexity should be 300 but got 302/');
396-
$this->graphQlQuery($query);
396+
//Use POST request because request uri is too large for some servers
397+
$this->graphQlMutation($query);
397398
}
398399

399400
/**

dev/tests/api-functional/testsuite/Magento/GraphQl/TestModule/GraphQlQueryTest.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function testQueryViaGetRequestReturnsResults()
7373
}
7474
QUERY;
7575

76-
$response = $this->graphQlQuery($query, [], '', [], 'GET');
76+
$response = $this->graphQlQuery($query, [], '', []);
7777

7878
$this->assertArrayHasKey('testItem', $response);
7979
}
@@ -83,8 +83,9 @@ public function testQueryViaGetRequestWithVariablesReturnsResults()
8383
$id = 1;
8484

8585
$query = <<<QUERY
86+
query getTestItem(\$id: Int!)
8687
{
87-
testItem(\$id: Int!)
88+
testItem(id: \$id)
8889
{
8990
item_id
9091
name
@@ -95,7 +96,7 @@ public function testQueryViaGetRequestWithVariablesReturnsResults()
9596
"id" => $id
9697
];
9798

98-
$response = $this->graphQlQuery($query, $variables, '', [], 'GET');
99+
$response = $this->graphQlQuery($query, $variables, '', []);
99100

100101
$this->assertArrayHasKey('testItem', $response);
101102
}

0 commit comments

Comments
 (0)