Skip to content

Commit 65593e2

Browse files
CE-33709: Fixed errors and warnings that were missed
1 parent 1dc1a0a commit 65593e2

File tree

27 files changed

+192
-60
lines changed

27 files changed

+192
-60
lines changed

app/code/Magento/CheckoutAgreements/Test/Unit/Model/Checkout/Plugin/GuestValidationTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ private function getPaymentExtension(): MockObject
174174
{
175175
$mockBuilder = $this->getMockBuilder(PaymentExtension::class);
176176
try {
177-
$mockBuilder->addMethods(['getAgreementIds']);
177+
$mockBuilder->onlyMethods(['getAgreementIds']);
178178
} catch (RuntimeException $e) {
179179
// Payment extension already generated.
180180
}

app/code/Magento/CheckoutAgreements/Test/Unit/Model/Checkout/Plugin/ValidationTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ private function getPaymentExtension(): MockObject
203203
{
204204
$mockBuilder = $this->getMockBuilder(PaymentExtension::class);
205205
try {
206-
$mockBuilder->addMethods(['getAgreementIds']);
206+
$mockBuilder->onlyMethods(['getAgreementIds']);
207207
} catch (RuntimeException $e) {
208208
// Payment extension already generated.
209209
}

app/code/Magento/Customer/Test/Unit/Observer/CatalogRule/AddCustomerGroupExcludedWebsiteTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ protected function setUp(): void
5050
->disableOriginalConstructor()
5151
->getMock();
5252
$this->ruleExtensionMock = $this->getMockBuilder(RuleExtension::class)
53-
->addMethods(['setExcludeWebsiteIds'])
53+
->onlyMethods(['setExcludeWebsiteIds'])
5454
->disableOriginalConstructor()
5555
->getMock();
5656
$this->observerMock->expects(self::atLeastOnce())

app/code/Magento/Downloadable/Test/Unit/Model/Quote/Item/CartItemProcessorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ private function getProductOptionExtensionMock(): MockObject
250250
{
251251
$mockBuilder = $this->getMockBuilder(ProductOptionExtension::class);
252252
try {
253-
$mockBuilder->addMethods(['setDownloadableOption']);
253+
$mockBuilder->onlyMethods(['setDownloadableOption']);
254254
} catch (RuntimeException $e) {
255255
// ProductOptionExtension already generated.
256256
}

app/code/Magento/GiftMessage/Test/Unit/Model/Plugin/OrderGetTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ private function getOrderExtensionMock(): MockObject
279279
{
280280
$mockObject = $this->getMockBuilder(OrderExtension::class);
281281
try {
282-
$mockObject->addMethods(['getGiftMessage', 'setGiftMessage']);
282+
$mockObject->onlyMethods(['getGiftMessage', 'setGiftMessage']);
283283
} catch (RuntimeException $e) {
284284
// Order extension already generated.
285285
}
@@ -296,7 +296,7 @@ private function getOrderItemExtensionMock(): MockObject
296296
{
297297
$mockObject = $this->getMockBuilder(OrderItemExtension::class);
298298
try {
299-
$mockObject->addMethods(['getGiftMessage', 'setGiftMessage']);
299+
$mockObject->onlyMethods(['getGiftMessage', 'setGiftMessage']);
300300
} catch (RuntimeException $e) {
301301
// Order extension already generated.
302302
}

app/code/Magento/GiftMessage/Test/Unit/Model/Plugin/OrderSaveTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ private function getOrderExtensionMock(): MockObject
199199
{
200200
$mockBuilder = $this->getMockBuilder(OrderExtension::class);
201201
try {
202-
$mockBuilder->addMethods(['getGiftMessage', 'setGiftMessage']);
202+
$mockBuilder->onlyMethods(['getGiftMessage', 'setGiftMessage']);
203203
} catch (RuntimeException $e) {
204204
// OrderExtension already generated.
205205
}
@@ -216,7 +216,7 @@ private function getOrderItemExtensionMock(): MockObject
216216
{
217217
$mockBuilder = $this->getMockBuilder(OrderItemExtension::class);
218218
try {
219-
$mockBuilder->addMethods(['getGiftMessage', 'setGiftMessage']);
219+
$mockBuilder->onlyMethods(['getGiftMessage', 'setGiftMessage']);
220220
} catch (RuntimeException $e) {
221221
// OrderItemExtension already generated.
222222
}

app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/Create/ConfigureProductToAddTest.php

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class ConfigureProductToAddTest extends TestCase
9595
private $configureProductToAdd;
9696

9797
/**
98-
* @inheritDoc
98+
* @inheritdoc
9999
*/
100100
protected function setUp(): void
101101
{
@@ -181,14 +181,10 @@ public function testExecute(): void
181181
->method('getParam')
182182
->with('id')
183183
->willReturn($productId);
184-
$this->objectManagerMock->expects($this->at(0))
184+
$this->objectManagerMock
185185
->method('get')
186-
->with(Quote::class)
187-
->willReturn($this->quoteSessionMock);
188-
$this->objectManagerMock->expects($this->at(1))
189-
->method('get')
190-
->with(Composite::class)
191-
->willReturn($this->compositeHelperMock);
186+
->withConsecutive([Quote::class], [Composite::class])
187+
->willReturnOnConsecutiveCalls($this->quoteSessionMock, $this->compositeHelperMock);
192188
$this->quoteSessionMock->expects($this->any())
193189
->method('getStore')
194190
->willReturn($this->storeMock);
@@ -208,6 +204,7 @@ public function testExecute(): void
208204
$this->compositeHelperMock->expects($this->once())
209205
->method('renderConfigureResult')
210206
->with($configureResult)->willReturn($this->layoutMock);
207+
211208
$this->assertInstanceOf(Layout::class, $this->configureProductToAdd->execute());
212209
}
213210
}

app/code/Magento/Sales/Test/Unit/Model/OrderRepositoryTest.php

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -253,15 +253,16 @@ private function getOrderExtensionMock(): MockObject
253253
{
254254
$mockBuilder = $this->getMockBuilder(OrderExtensionInterface::class)->disableOriginalConstructor();
255255
try {
256-
$mockBuilder->addMethods(
257-
[
258-
'getShippingAssignments',
259-
'setAppliedTaxes',
260-
'setConvertingFromQuote',
261-
'setItemAppliedTaxes',
262-
'setPaymentAdditionalInfo',
263-
]
264-
);
256+
$mockBuilder
257+
->onlyMethods(
258+
[
259+
'getShippingAssignments',
260+
'setAppliedTaxes',
261+
'setConvertingFromQuote',
262+
'setItemAppliedTaxes',
263+
'setPaymentAdditionalInfo'
264+
]
265+
);
265266
} catch (RuntimeException $e) {
266267
// Order extension already generated.
267268
}

app/code/Magento/Tax/Test/Unit/Model/Plugin/OrderSaveTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ protected function setupExtensionAttributeMock(): MockObject
108108
{
109109
$orderExtensionAttributeMock = $this->getMockBuilder(OrderExtensionInterface::class)
110110
->disableOriginalConstructor()
111-
->addMethods(
111+
->onlyMethods(
112112
[
113113
'getAppliedTaxes',
114114
'getConvertingFromQuote',

app/code/Magento/WeeeGraphQl/Test/Unit/Model/Resolver/FixedProductTaxResolverTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,8 @@ protected function setUp(): void
128128
->getMock();
129129

130130
$this->contextExtensionAttributesMock = $this->getMockBuilder(ContextExtensionInterface::class)
131-
->addMethods(['getStore'])
132-
->getMock();
131+
->onlyMethods(['getStore'])
132+
->getMockForAbstractClass();
133133
$this->storeMock = $this->createMock(StoreInterface::class);
134134
$this->cartItemMock = $this->createMock(CartItemInterface::class);
135135
$this->fieldMock = $this->createMock(Field::class);

0 commit comments

Comments
 (0)