Skip to content

Commit 65378b9

Browse files
committed
refactoring
1 parent 6025197 commit 65378b9

File tree

4 files changed

+27
-6
lines changed

4 files changed

+27
-6
lines changed

app/code/Magento/Integration/Test/Mftf/ActionGroup/AdminCreatesNewIntegrationActionGroup.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,5 @@
1717
</arguments>
1818
<fillField stepKey="fillNameField" selector="{{AddNewIntegrationSection.name}}" userInput="{{name}}"/>
1919
<fillField stepKey="fillAdminPasswordField" selector="{{AddNewIntegrationSection.password}}" userInput="{{password}}"/>
20-
<!--Click the "Save" Button -->
21-
<click stepKey="clickSaveButton" selector="{{AddNewIntegrationSection.saveButton}}"/>
2220
</actionGroup>
2321
</actionGroups>
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
12+
<actionGroup name="AdminSubmitNewIntegrationFormActionGroup">
13+
<!--Click the "Save" Button -->
14+
<click stepKey="clickSaveButton" selector="{{AddNewIntegrationSection.saveButton}}"/>
15+
<waitForPageLoad stepKey="waitForPageLoad"/>
16+
</actionGroup>
17+
</actionGroups>

app/code/Magento/Integration/Test/Mftf/Section/AdminIntegrationsSection.xml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,22 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1010

1111
<section name="IntegrationsGridSection">
12-
<element name="add" type="button" selector=".add"/>
12+
<element name="add" type="button" selector=".page-actions .add"/>
1313
<element name="messageByType" type="block" selector="#messages .message-{{messageType}}" parameterized="true"/>
14-
<element name="name" type="input" selector="#integrationGrid_filter_name"/>
14+
<element name="name" type="input" selector=".data-grid-filters #integrationGrid_filter_name"/>
1515
<element name="search" type="input" selector=".admin__filter-actions button[title=Search]"/>
16-
<element name="remove" type="button" selector=".delete"/>
16+
<element name="remove" type="button" selector=".data-grid .delete"/>
1717
<element name="submitButton" type="button" selector=".action-primary.action-accept" timeout="30"/>
1818
<element name="rowByIndex" type="text" selector="tr[data-role='row']:nth-of-type({{var1}})" parameterized="true" timeout="30"/>
19+
<element name="edit" type="button" selector=".data-grid .edit"/>
1920
</section>
2021

2122
<section name="AddNewIntegrationSection">
2223
<element name="name" type="input" selector="#integration_properties_name"/>
2324
<element name="password" type="input" selector="#integration_properties_current_password"/>
24-
<element name="saveButton" type="button" selector="#save-split-button-button"/>
25+
<element name="saveButton" type="button" selector=".page-actions #save-split-button-button"/>
26+
<element name="endpoint" type="input" selector="#integration_properties_endpoint"/>
27+
<element name="linkUrl" type="input" selector="#integration_properties_identity_link_url"/>
28+
<element name="save" type="button" selector=".page-actions-buttons .save"/>
2529
</section>
2630
</sections>

app/code/Magento/Integration/Test/Mftf/Test/AdminDeleteIntegrationEntityTest.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
<argument name="name" value="Integration1"/>
3333
<argument name="password" value="{{_ENV.MAGENTO_ADMIN_PASSWORD}}"/>
3434
</actionGroup>
35+
<!-- Submit The Form -->
36+
<actionGroup ref="AdminSubmitNewIntegrationFormActionGroup" stepKey="submitTheForm"/>
3537
</before>
3638
<after>
3739
<actionGroup ref="logout" stepKey="logout"/>

0 commit comments

Comments
 (0)