Skip to content

Commit 64dcbea

Browse files
committed
Return void instead of [] from before plugin if no arguments are modified
1 parent cd7a64e commit 64dcbea

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

lib/internal/Magento/Framework/App/Action/Plugin/ActionFlagNoDispatchPlugin.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
use Magento\Framework\App\ActionInterface;
77
use Magento\Framework\App\ResponseInterface;
88

9+
/**
10+
*
11+
*/
912
class ActionFlagNoDispatchPlugin
1013
{
1114
/**
@@ -28,7 +31,7 @@ public function __construct(ActionFlag $actionFlag, ResponseInterface $response)
2831
* @param ActionInterface $subject
2932
* @param callable $proceed
3033
* @return ResponseInterface
31-
*
34+
*
3235
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
3336
*/
3437
public function aroundExecute(ActionInterface $subject, callable $proceed)

lib/internal/Magento/Framework/App/Action/Plugin/EventDispatchPlugin.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
use Magento\Framework\Event\ManagerInterface;
1212
use Magento\Framework\HTTP\PhpEnvironment\Response;
1313

14+
/**
15+
*
16+
*/
1417
class EventDispatchPlugin
1518
{
1619
/**
@@ -38,8 +41,6 @@ public function __construct(RequestInterface $request, ManagerInterface $eventMa
3841
public function beforeExecute(ActionInterface $subject)
3942
{
4043
$this->dispatchPreDispatchEvents($subject);
41-
42-
return [];
4344
}
4445

4546
/**

0 commit comments

Comments
 (0)