MAGETWO-89247: Run catalog search indexer by dimension

Author: mslabko

lib/internal/Magento/Framework/MultiDimensionalIndexer/Dimension.php

@@ -7,40 +7,13 @@
 
 namespace Magento\Framework\MultiDimensionalIndexer;
 
+use Magento\Framework\Search\AbstractKeyValuePair;
+
 /**
  * Index Dimension object
  *
  * @api
  */
-class Dimension
+class Dimension extends AbstractKeyValuePair
 {
-    /**
-     * @param string $name
-     * @param string $value
-     */
-    public function __construct(string $name, string $value)
-    {
-        $this->name = $name;
-        $this->value = $value;
-    }
-
-    /**
-     * Get dimension name
-     *
-     * @return string
-     */
-    public function getName(): string
-    {
-        return $this->name;
-    }
-
-    /**
-     * Get dimension value
-     *
-     * @return string
-     */
-    public function getValue(): string
-    {
-        return $this->value;
-    }
 }

lib/internal/Magento/Framework/MultiDimensionalIndexer/DimensionFactory.php

@@ -30,15 +30,11 @@ public function __construct(ObjectManagerInterface $objectManager)
     }
 
     /**
-     * @param string $name
-     * @param string $value
+     * @param array $arguments
      * @return Dimension
      */
-    public function create(string $name, $value): Dimension
+    public function create(array $arguments = []): Dimension
     {
-        return $this->objectManager->create(Dimension::class, [
-            'name' => $name,
-            'value' => (string) $value,
-        ]);
+        return $this->objectManager->create(Dimension::class, $arguments);
     }
 }

lib/internal/Magento/Framework/MultiDimensionalIndexer/IndexNameBuilder.php

@@ -83,7 +83,10 @@ public function setIndexId(string $indexId): self
      */
     public function addDimension(string $name, string $value): self
     {
-        $this->data[self::$dimensions][] = $this->dimensionFactory->create($name, $value);
+        $this->data[self::$dimensions][] = $this->dimensionFactory->create([
+            'name' => $name,
+            'value' => $value,
+        ]);
         return $this;
     }