Skip to content

Commit 63fea91

Browse files
ENGCOM-6285: The image details are not hidden when click on same image #25566
- Merge Pull Request #25566 from Nazar65/magento2:ASI-690 - Merged commits: 1. f070206 2. c23393d 3. aa7195a 4. e29914e 5. a565ee0 6. b30b855 7. a7ffbd6 8. e5d143d
2 parents e34c795 + e5d143d commit 63fea91

File tree

2 files changed

+56
-0
lines changed

2 files changed

+56
-0
lines changed

app/code/Magento/Ui/view/base/web/js/grid/columns/image-preview.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,12 @@ define([
106106
show: function (record) {
107107
var img;
108108

109+
if (record._rowIndex === this.visibleRecord()) {
110+
this.hide();
111+
112+
return;
113+
}
114+
109115
this.hide();
110116
this.displayedRecord(record);
111117
this._selectRow(record.rowNumber || null);
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
/**
2+
* Copyright © Magento, Inc. All rights reserved.
3+
* See COPYING.txt for license details.
4+
*/
5+
/* eslint-disable max-nested-callbacks, no-undef */
6+
7+
define([
8+
'Magento_Ui/js/grid/columns/image-preview',
9+
'ko',
10+
'jquery'
11+
], function (Preview, ko, $) {
12+
'use strict';
13+
14+
describe('Ui/js/grid/columns/image-preview', function () {
15+
var record = {
16+
_rowIndex: 1,
17+
rowNumber: 1
18+
},
19+
imagePreview;
20+
21+
beforeEach(function () {
22+
imagePreview = new Preview();
23+
24+
/**
25+
* @return {Object}
26+
*/
27+
function getThumbnail() {
28+
return {
29+
previewRowId: ko.observable()
30+
};
31+
}
32+
33+
imagePreview.thumbnailComponent = getThumbnail;
34+
35+
imagePreview.visibleRecord = ko.observable(1);
36+
});
37+
38+
describe('show method', function () {
39+
it('show image', function () {
40+
var mockImg = document.createElement('img'),
41+
hide = spyOn(imagePreview, 'hide');
42+
43+
spyOn($.fn, 'get').and.returnValue(mockImg);
44+
imagePreview.show(record);
45+
expect(hide).toHaveBeenCalledTimes(1);
46+
});
47+
48+
});
49+
});
50+
});

0 commit comments

Comments
 (0)