Skip to content

Commit 63f6535

Browse files
author
Stanislav Idolov
authored
ENGCOM-2744: Added translation comment tags #17519 
2 parents 538b16f + 8d96de1 commit 63f6535

File tree

7 files changed

+21
-37
lines changed

7 files changed

+21
-37
lines changed

‎app/code/Magento/Ui/etc/adminhtml/system.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99
<system>
1010
<section id="dev">
1111
<group id="js">
12-
<field id="session_storage_logging" translate="label" type="select" sortOrder="100" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
12+
<field id="session_storage_logging" translate="label comment" type="select" sortOrder="100" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
1313
<label>Log JS Errors to Session Storage</label>
1414
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
1515
<comment>If enabled, can be used by functional tests for extended reporting</comment>
1616
</field>
17-
<field id="session_storage_key" translate="label" type="text" sortOrder="110" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
17+
<field id="session_storage_key" translate="label comment" type="text" sortOrder="110" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
1818
<label>Log JS Errors to Session Storage Key</label>
1919
<comment>Use this key to retrieve collected js errors</comment>
2020
</field>

‎app/code/Magento/Ui/i18n/en_US.csv

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -125,30 +125,18 @@ Ok,Ok
125125
"Label Actions Two","Label Actions Two"
126126
"Some Dynamic Actions","Some Dynamic Actions"
127127
"Log JS Errors to Session Storage","Log JS Errors to Session Storage"
128+
"If enabled, can be used by functional tests for extended reporting","If enabled, can be used by functional tests for extended reporting"
128129
"Log JS Errors to Session Storage Key","Log JS Errors to Session Storage Key"
130+
"Use this key to retrieve collected js errors","Use this key to retrieve collected js errors"
129131
settings/label,settings/label
130132
settings/confirm/title,settings/confirm/title
131-
"settings/confirm/message
132-
","settings/confirm/message
133-
"
134-
"
135-
settings/callback/provider
136-
","
137-
settings/callback/provider
138-
"
139-
"settings/callback/target
140-
","settings/callback/target
141-
"
142-
"settings/newViewLabel
143-
","settings/newViewLabel
144-
"
133+
"settings/confirm/message","settings/confirm/message"
134+
"settings/callback/provider","settings/callback/provider"
135+
"settings/callback/target","settings/callback/target"
136+
"settings/newViewLabel","settings/newViewLabel"
145137
settings/title,settings/title
146138
settings/description,settings/description
147-
"
148-
settings/addButtonLabel
149-
","
150-
settings/addButtonLabel
151-
"
139+
"settings/addButtonLabel","settings/addButtonLabel"
152140
"
153141
formElements/*[name(.)=../../@formElement]/settings/description
154142
","

‎app/code/Magento/Ui/view/base/ui_component/etc/definition.map.xml

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,11 @@
1616
<item name="url" type="url" xsi:type="converter">settings/url</item>
1717
<item name="confirm" xsi:type="array">
1818
<item name="title" type="string" translate="true" xsi:type="xpath">settings/confirm/title</item>
19-
<item name="message" type="string" translate="true" xsi:type="xpath">settings/confirm/message
20-
</item>
19+
<item name="message" type="string" translate="true" xsi:type="xpath">settings/confirm/message</item>
2120
</item>
2221
<item name="callback" xsi:type="array">
23-
<item name="provider" type="string" translate="true" xsi:type="xpath">
24-
settings/callback/provider
25-
</item>
26-
<item name="target" type="string" translate="true" xsi:type="xpath">settings/callback/target
27-
</item>
22+
<item name="provider" type="string" translate="true" xsi:type="xpath">settings/callback/provider</item>
23+
<item name="target" type="string" translate="true" xsi:type="xpath">settings/callback/target</item>
2824
</item>
2925
</item>
3026
</argument>
@@ -59,8 +55,7 @@
5955
<item name="config" xsi:type="array">
6056
<item name="childDefaults" type="item" xsi:type="converter">settings/childDefaults</item>
6157
<item name="viewTmpl" type="string" xsi:type="xpath">settings/viewTmpl</item>
62-
<item name="newViewLabel" translate="true" type="string" xsi:type="xpath">settings/newViewLabel
63-
</item>
58+
<item name="newViewLabel" translate="true" type="string" xsi:type="xpath">settings/newViewLabel</item>
6459
</item>
6560
</argument>
6661
</schema>
@@ -265,9 +260,7 @@
265260
<item name="columnsHeaderClasses" type="string" xsi:type="xpath">settings/columnsHeaderClasses</item>
266261
<item name="recordTemplate" type="string" xsi:type="xpath">settings/recordTemplate</item>
267262
<item name="collapsibleHeader" type="boolean" xsi:type="xpath">settings/collapsibleHeader</item>
268-
<item name="addButtonLabel" type="string" translate="true" xsi:type="xpath">
269-
settings/addButtonLabel
270-
</item>
263+
<item name="addButtonLabel" type="string" translate="true" xsi:type="xpath">settings/addButtonLabel</item>
271264
<item name="addButton" type="boolean" xsi:type="xpath">settings/addButton</item>
272265
<item name="deleteProperty" type="string" xsi:type="xpath">settings/deleteProperty</item>
273266
<item name="identificationProperty" type="string" xsi:type="xpath">settings/identificationProperty</item>

‎app/code/Magento/WebapiSecurity/etc/adminhtml/system.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
-->
66
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Config:etc/system_file.xsd">
77
<system>
8-
<section id="webapi" translate="label" type="text" sortOrder="102" showInDefault="1" showInWebsite="1" showInStore="1">
8+
<section id="webapi" type="text" sortOrder="102" showInDefault="1" showInWebsite="1" showInStore="1">
99
<group id="webapisecurity" translate="label" type="text" sortOrder="250" showInDefault="1" showInWebsite="0" showInStore="0">
1010
<label>Web API Security</label>
11-
<field id="allow_insecure" translate="label" type="select" sortOrder="1" showInDefault="1" showInWebsite="0" showInStore="0">
11+
<field id="allow_insecure" translate="label" type="select comment" sortOrder="1" showInDefault="1" showInWebsite="0" showInStore="0">
1212
<label>Allow Anonymous Guest Access</label>
1313
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
1414
<comment>This feature applies only to CMS, Catalog and Store APIs. Please consult your developers for details on potential security risks.</comment>

‎app/code/Magento/WebapiSecurity/i18n/en_US.csv

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
"Web API Security","Web API Security"
22
"Allow Anonymous Guest Access","Allow Anonymous Guest Access"
3+
"This feature applies only to CMS, Catalog and Store APIs. Please consult your developers for details on potential security risks.","This feature applies only to CMS, Catalog and Store APIs. Please consult your developers for details on potential security risks."

‎app/code/Magento/Wishlist/etc/adminhtml/system.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@
2222
<comment>Email template chosen based on theme fallback when "Default" option is selected.</comment>
2323
<source_model>Magento\Config\Model\Config\Source\Email\Template</source_model>
2424
</field>
25-
<field id="number_limit" translate="label" type="text" sortOrder="3" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
25+
<field id="number_limit" translate="label comment" type="text" sortOrder="3" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
2626
<label>Max Emails Allowed to be Sent</label>
2727
<comment>10 by default. Max - 10000</comment>
2828
<validate>validate-digits validate-digits-range digits-range-1-10000</validate>
2929
</field>
30-
<field id="text_limit" translate="label" type="text" sortOrder="4" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
30+
<field id="text_limit" translate="label comment" type="text" sortOrder="4" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
3131
<label>Email Text Length Limit</label>
3232
<comment>255 by default</comment>
3333
<validate>validate-digits validate-digits-range digits-range-1-10000</validate>

‎app/code/Magento/Wishlist/i18n/en_US.csv

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,9 @@ Back,Back
9999
"Email Template","Email Template"
100100
"Email template chosen based on theme fallback when ""Default"" option is selected.","Email template chosen based on theme fallback when ""Default"" option is selected."
101101
"Max Emails Allowed to be Sent","Max Emails Allowed to be Sent"
102+
"10 by default. Max - 10000","10 by default. Max - 10000"
102103
"Email Text Length Limit","Email Text Length Limit"
104+
"255 by default","255 by default"
103105
"General Options","General Options"
104106
Enabled,Enabled
105107
"My Wish List Link","My Wish List Link"

0 commit comments

Comments
 (0)