Skip to content

Commit 63f0720

Browse files
author
Hwashiang Yu
committed
MC-16877: Eliminate @escapeNotVerified in Catalog Inventory Modules
- Resolved incorrect escapes
1 parent 747ce64 commit 63f0720

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

app/code/Magento/CatalogInventory/view/frontend/templates/qtyincrements.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@
1010
?>
1111
<?php if ($block->getProductQtyIncrements()) : ?>
1212
<div class="product pricing">
13-
<?= /* @noEscape */ __('%1 is available to buy in increments of %2', $block->escapeHtml($block->getProductName()), $block->escapeHtml($block->getProductQtyIncrements())) ?>
13+
<?= $block->escapeHtml(__('%1 is available to buy in increments of %2', $block->getProductName(), $block->getProductQtyIncrements())) ?>
1414
</div>
1515
<?php endif ?>

app/code/Magento/CatalogInventory/view/frontend/templates/stockqty/composite.phtml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
<a href="#"
1414
data-mage-init='{"toggleAdvanced": {"selectorsToggleClass": "active", "baseToggleClass": "expanded", "toggleContainers": "#<?= $block->escapeHtmlAttr($block->getDetailsPlaceholderId()) ?>"}}'
1515
id="<?= $block->escapeHtmlAttr($block->getPlaceholderId()) ?>"
16-
title="<?= /* @noEscape */ __('Only %1 left', ($block->escapeHtmlAttr($block->getStockQtyLeft()))) ?>"
16+
title="<?= $block->escapeHtmlAttr(__('Only %1 left', ($block->getStockQtyLeft()))) ?>"
1717
class="action show">
18-
<?= /* @noEscape */ __('Only %1 left', "<strong>{$block->escapeHtml($block->getStockQtyLeft())}</strong>") ?>
18+
<?= $block->escapeHtml(__('Only %1 left', "<strong>{$block->getStockQtyLeft()}</strong>")) ?>
1919
</a>
2020
</div>
2121
<div class="availability only detailed" id="<?= $block->escapeHtmlAttr($block->getDetailsPlaceholderId()) ?>">
@@ -33,8 +33,8 @@
3333
<?php $childProductStockQty = $block->getProductStockQty($childProduct); ?>
3434
<?php if ($childProductStockQty > 0) : ?>
3535
<tr>
36-
<td data-th="<?= $block->escapeHtml(__('Product Name')) ?>" class="col item"><?= $block->escapeHtml($childProduct->getName()) ?></td>
37-
<td data-th="<?= $block->escapeHtml(__('Qty')) ?>" class="col qty"><?= $block->escapeHtml($childProductStockQty) ?></td>
36+
<td data-th="<?= $block->escapeHtmlAttr(__('Product Name')) ?>" class="col item"><?= $block->escapeHtml($childProduct->getName()) ?></td>
37+
<td data-th="<?= $block->escapeHtmlAttr(__('Qty')) ?>" class="col qty"><?= $block->escapeHtml($childProductStockQty) ?></td>
3838
</tr>
3939
<?php endif ?>
4040
<?php endforeach ?>

app/code/Magento/CatalogInventory/view/frontend/templates/stockqty/default.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
*/
1010
?>
1111
<?php if ($block->isMsgVisible()) : ?>
12-
<div class="availability only" title="<?= /* @noEscape */ __('Only %1 left', ($block->escapeHtmlAttr($block->getStockQtyLeft()))) ?>">
13-
<?= /* @noEscape */ __('Only %1 left', "<strong>{$block->escapeHtml($block->getStockQtyLeft())}</strong>") ?>
12+
<div class="availability only" title="<?= $block->escapeHtmlAttr(__('Only %1 left', ($block->getStockQtyLeft()))) ?>">
13+
<?= $block->escapeHtml(__('Only %1 left', "<strong>{$block->getStockQtyLeft()}</strong>")) ?>
1414
</div>
1515
<?php endif ?>

0 commit comments

Comments
 (0)