ACPT-1194

fixing static test failures

Author: JacobBrownAustin

app/code/Magento/Catalog/Model/Product/Attribute/Backend/GroupPrice/AbstractGroupPrice.php

@@ -40,8 +40,6 @@ abstract class AbstractGroupPrice extends Price implements ResetAfterRequestInte
     abstract protected function _getDuplicateErrorMessage();
 
     /**
-     * Catalog product type
-     *
      * @var \Magento\Catalog\Model\Product\Type
      */
     protected $_catalogProductType;

app/code/Magento/Eav/Model/Config.php

@@ -990,8 +990,8 @@ public function _resetState(): void
     {
         $this->attributesPerSet = [];
         $this->_attributeData = [];
-        foreach($this->attributes as $attributesGroupedByEntityTypeCode) {
-            foreach($attributesGroupedByEntityTypeCode as $attribute) {
+        foreach ($this->attributes as $attributesGroupedByEntityTypeCode) {
+            foreach ($attributesGroupedByEntityTypeCode as $attribute) {
                 if ($attribute instanceof ResetAfterRequestInterface) {
                     $attribute->_resetState();
                 }

app/code/Magento/Eav/Model/Entity/Attribute/AbstractAttribute.php

@@ -27,12 +27,12 @@ abstract class AbstractAttribute extends \Magento\Framework\Model\AbstractExtens
     \Magento\Eav\Api\Data\AttributeInterface,
     ResetAfterRequestInterface
 {
-    const TYPE_STATIC = 'static';
+    public const TYPE_STATIC = 'static';
 
     /**
      * Const for empty string value.
      */
-    const EMPTY_STRING = '';
+    public const EMPTY_STRING = '';
 
     /**
      * Attribute name
@@ -70,8 +70,6 @@ abstract class AbstractAttribute extends \Magento\Framework\Model\AbstractExtens
     protected $_source;
 
     /**
-     * Attribute id cache
-     *
      * @var array
      */
     protected $_attributeIdCache = [];
@@ -231,8 +229,6 @@ public function _resetState() : void
     /**
      * Get Serializer instance.
      *
-     * @deprecated 101.0.0
-     *
      * @return Json
      * @since 101.0.0
      */
@@ -241,7 +237,6 @@ protected function getSerializer()
         if ($this->serializer === null) {
             $this->serializer = \Magento\Framework\App\ObjectManager::getInstance()->create(Json::class);
         }
-
         return $this->serializer;
     }
 
@@ -942,6 +937,7 @@ public function _getFlatColumnsDdlDefinition()
      * Used in database compatible mode
      *
      * @deprecated 101.0.0
+     * @see MMDB
      * @return array
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */