MAGETWO-36063: Update REST and SOAP controllers to filter out attributes based on ACL

- Fix static analysis

Author: Bryant Luk

app/code/Magento/Webapi/Test/Unit/Model/DataObjectProcessorTest.php

@@ -23,13 +23,15 @@ class DataObjectProcessorTest extends \PHPUnit_Framework_TestCase
     protected function setup()
     {
         $objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
-        $methodsMapProcessor = $objectManager->getObject('Magento\Framework\Reflection\MethodsMap',
+        $methodsMapProcessor = $objectManager->getObject(
+            'Magento\Framework\Reflection\MethodsMap',
             [
                 'fieldNamer' => $objectManager->getObject('Magento\Framework\Reflection\FieldNamer'),
                 'typeProcessor' => $objectManager->getObject('Magento\Framework\Reflection\TypeProcessor'),
             ]
         );
-        $this->dataObjectProcessor = $objectManager->getObject('Magento\Framework\Reflection\DataObjectProcessor',
+        $this->dataObjectProcessor = $objectManager->getObject(
+            'Magento\Framework\Reflection\DataObjectProcessor',
             [
                 'methodsMapProcessor' => $methodsMapProcessor,
                 'typeCaster' => $objectManager->getObject('Magento\Framework\Reflection\TypeCaster'),

lib/internal/Magento/Framework/Reflection/DataObjectProcessor.php

@@ -78,7 +78,7 @@ public function buildOutputDataArray($dataObject, $dataObjectType)
         $outputData = [];
 
         /** @var MethodReflection $method */
-        foreach ($methods as $methodName => $methodReflectionData) {
+        foreach (array_keys($methods) as $methodName) {
             if (!$this->methodsMapProcessor->isMethodValidForDataField($dataObjectType, $methodName)) {
                 continue;
             }

lib/internal/Magento/Framework/Reflection/ExtensionAttributesProcessor.php

@@ -88,14 +88,15 @@ public function __construct(
      * @param ExtensionAttributeInterface $dataObject
      * @param string $dataObjectType
      * @return array
+     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     public function buildOutputDataArray(ExtensionAttributesInterface $dataObject, $dataObjectType)
     {
         $methods = $this->methodsMapProcessor->getMethodsMap($dataObjectType);
         $outputData = [];
 
         /** @var MethodReflection $method */
-        foreach ($methods as $methodName => $methodReflectionData) {
+        foreach (array_keys($methods) as $methodName) {
             if (!$this->methodsMapProcessor->isMethodValidForDataField($dataObjectType, $methodName)) {
                 continue;
             }

lib/internal/Magento/Framework/Reflection/FieldNamer.php

@@ -23,7 +23,7 @@ class FieldNamer
     const GETTER_PREFIX = 'get';
 
     /**
-     * @param string
+     * @param string $methodName
      * @return string|null
      */
     public function getFieldNameForMethodName($methodName)