ENGCOM-5787: Fix for bug: If multiple children had the same sort order only one of… #24457

sidolov · web-flow · commit 630b35290852 · 2019-09-09T14:13:49.000-05:00
diff --git a/app/code/Magento/Catalog/Block/Product/View/Details.php b/app/code/Magento/Catalog/Block/Product/View/Details.php
@@ -37,11 +37,11 @@ public function getGroupSortedChildNames(string $groupName, string $callback): a
             $alias = $layout->getElementAlias($childName);
             $sortOrder = (int)$this->getChildData($alias, 'sort_order') ?? 0;
 
-            $childNamesSortOrder[$sortOrder] = $childName;
+            $childNamesSortOrder[$childName] = $sortOrder;
         }
 
-        ksort($childNamesSortOrder, SORT_NUMERIC);
+        asort($childNamesSortOrder, SORT_NUMERIC);
 
-        return $childNamesSortOrder;
+        return array_keys($childNamesSortOrder);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -37,11 +37,11 @@ public function getGroupSortedChildNames(string $groupName, string $callback): a`
`37`	`37`	`$alias = $layout->getElementAlias($childName);`
`38`	`38`	`$sortOrder = (int)$this->getChildData($alias, 'sort_order') ?? 0;`
`39`	`39`
`40`		`- $childNamesSortOrder[$sortOrder] = $childName;`
	`40`	`+ $childNamesSortOrder[$childName] = $sortOrder;`
`41`	`41`	`}`
`42`	`42`
`43`		`- ksort($childNamesSortOrder, SORT_NUMERIC);`
	`43`	`+ asort($childNamesSortOrder, SORT_NUMERIC);`
`44`	`44`
`45`		`- return $childNamesSortOrder;`
	`45`	`+ return array_keys($childNamesSortOrder);`
`46`	`46`	`}`
`47`	`47`	`}`