🔃 [EngCom] Public Pull Requests - 2.1-develop

magento-engcom-team · web-flow · commit 63055ea34abc · 2018-04-04T17:50:05.000+03:00
Accepted Public Pull Requests: - #14505: [Backport] Check if store id is not null instead of empty (by @quisse)
diff --git a/app/code/Magento/Cms/Model/PageRepository.php b/app/code/Magento/Cms/Model/PageRepository.php
@@ -102,7 +102,7 @@ public function __construct(
      */
     public function save(\Magento\Cms\Api\Data\PageInterface $page)
     {
-        if (empty($page->getStoreId())) {
+        if ($page->getStoreId() === null) {
             $storeId = $this->storeManager->getStore()->getId();
             $page->setStoreId($storeId);
         }

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ public function __construct(`
`102`	`102`	`*/`
`103`	`103`	`public function save(\Magento\Cms\Api\Data\PageInterface $page)`
`104`	`104`	`{`
`105`		`- if (empty($page->getStoreId())) {`
	`105`	`+ if ($page->getStoreId() === null) {`
`106`	`106`	`$storeId = $this->storeManager->getStore()->getId();`
`107`	`107`	`$page->setStoreId($storeId);`
`108`	`108`	`}`