MAGETWO-96432: Payment method title does not update in the admin sales order grid

- Change title definition logic for offline payment methods

Author: nikshostko

app/code/Magento/Payment/Helper/Data.php

@@ -261,11 +261,10 @@ public function getPaymentMethodList($sorted = true, $asLabelValue = false, $wit
         $groupRelations = [];
 
         foreach ($this->getPaymentMethods() as $code => $data) {
-            $storedTitle = $this->getMethodInstance($code)->getConfigData('title', $store);
-            if (isset($storedTitle)) {
-                $methods[$code] = $storedTitle;
-            } elseif (isset($data['title'])) {
+            if (isset($data['title'])) {
                 $methods[$code] = $data['title'];
+            } else {
+                $methods[$code] = $this->getMethodInstance($code)->getConfigData('title', $store);
             }
             if ($asLabelValue && $withGroups && isset($data['group'])) {
                 $groupRelations[$code] = $data['group'];

app/code/Magento/Payment/Ui/Component/Listing/Column/Method/Options.php

@@ -5,6 +5,9 @@
  */
 namespace Magento\Payment\Ui\Component\Listing\Column\Method;
 
+use Magento\Payment\Api\PaymentMethodListInterface;
+use Magento\Store\Model\StoreManagerInterface;
+
 /**
  * Class Options
  */
@@ -20,14 +23,29 @@ class Options implements \Magento\Framework\Data\OptionSourceInterface
      */
     protected $paymentHelper;
 
+    /**
+     * @var PaymentMethodListInterface
+     */
+    private $paymentMethodList;
+
+    /**
+     * @var StoreManagerInterface
+     */
+    private $storeManager;
+
     /**
      * Constructor
      *
      * @param \Magento\Payment\Helper\Data $paymentHelper
      */
-    public function __construct(\Magento\Payment\Helper\Data $paymentHelper)
-    {
+    public function __construct(
+        \Magento\Payment\Helper\Data $paymentHelper,
+        \Magento\Payment\Api\PaymentMethodListInterface $paymentMethodList,
+        \Magento\Store\Model\StoreManagerInterface $storeManager
+    ) {
         $this->paymentHelper = $paymentHelper;
+        $this->paymentMethodList = $paymentMethodList;
+        $this->storeManager = $storeManager;
     }
 
     /**
@@ -38,8 +56,23 @@ public function __construct(\Magento\Payment\Helper\Data $paymentHelper)
     public function toOptionArray()
     {
         if ($this->options === null) {
-            $this->options = $this->paymentHelper->getPaymentMethodList(true, true);
+            $this->options = $this->getPaymentOptions();
+//            $this->options = $this->paymentHelper->getPaymentMethodList(true, true);
         }
         return $this->options;
     }
+
+    /**
+     * @return array
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
+     */
+    private function getPaymentOptions()
+    {
+        $options = [];
+        foreach ($this->paymentMethodList->getList($this->storeManager->getStore()->getId()) as $option) {
+            $options[$option->getCode()] = ['value' => $option->getCode(), 'label' => $option->getTitle()];
+        }
+        asort($options);
+        return $options;
+    }
 }