MC-32278: Position sort does not work in GraphQl.

cpartica · cpartica · commit 61b8d6bde7b0 · 2020-03-16T15:07:37.000-05:00
- fix static
diff --git a/app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/ProductSearch/ProductCollectionSearchCriteriaBuilder.php b/app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/ProductSearch/ProductCollectionSearchCriteriaBuilder.php
@@ -14,11 +14,15 @@
 use Magento\Framework\Api\Search\SearchCriteriaInterfaceFactory;
 use Magento\Framework\Api\SearchCriteriaInterface;
 
+/**
+ * Builds a search criteria intended for the product collection based on search criteria used on SearchAPI
+ */
 class ProductCollectionSearchCriteriaBuilder
 {
-    /**
-     * @var SearchCriteriaInterfaceFactory
-     */
+    /** @var CollectionFactory */
+    private $collectionFactory;
+
+    /** @var SearchCriteriaInterfaceFactory */
     private $searchCriteriaFactory;
 
     /** @var FilterBuilder */
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductSearchTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductSearchTest.php
@@ -1121,6 +1121,7 @@ public function testFilterWithinSpecificPriceRangeSortedByNameDesc()
 
     /**
      * @magentoApiDataFixture Magento/Catalog/_files/category_with_three_products.php
+     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
      */
     public function testSortByPosition()
     {

Original file line number	Diff line number	Diff line change
`@@ -1121,6 +1121,7 @@ public function testFilterWithinSpecificPriceRangeSortedByNameDesc()`
`1121`	`1121`
`1122`	`1122`	`/**`
`1123`	`1123`	`* @magentoApiDataFixture Magento/Catalog/_files/category_with_three_products.php`
	`1124`	`+ * @SuppressWarnings(PHPMD.UnusedLocalVariable)`
`1124`	`1125`	`*/`
`1125`	`1126`	`public function testSortByPosition()`
`1126`	`1127`	`{`