Skip to content

Commit 60efe62

Browse files
author
Devagouda Patil
committed
MC-5593: [Modularity] Braintree module MFTF contain wide used sections and action groups
- removed unwanted wait paramateres from waitForPageLoad
1 parent 1dc27c1 commit 60efe62

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

app/code/Magento/Braintree/Test/Mftf/Test/CreateAnAdminOrderUsingBraintreePaymentTest1.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@
7474
<actionGroup ref="useBraintreeForMasterCard" stepKey="selectCardWithBraintree"/>
7575

7676
<click stepKey="submitOrder" selector="{{NewOrderSection.submitOrder}}"/>
77-
<waitForPageLoad stepKey="waitForSaveConfig" time="5"/>
78-
<waitForElementVisible selector="{{NewOrderSection.successMessage}}" stepKey="waitForSuccessMessage" time="1"/>
77+
<waitForPageLoad stepKey="waitForSaveConfig"/>
78+
<waitForElementVisible selector="{{NewOrderSection.successMessage}}" stepKey="waitForSuccessMessage"/>
7979

8080
<after>
8181
<!-- Disable BrainTree -->

app/code/Magento/Sales/Test/Mftf/ActionGroup/CreateNewOrderActionGroup.xml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,30 +9,26 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="useBraintreeForMasterCard">
1111
<click stepKey="chooseBraintree" selector="{{NewOrderSection.creditCardBraintree}}"/>
12-
<waitForPageLoad stepKey="waitForBraintreeConfigs" time="5"/>
12+
<waitForPageLoad stepKey="waitForBraintreeConfigs"/>
1313
<click stepKey="openCardTypes" selector="{{NewOrderSection.openCardTypes}}"/>
14-
<waitForPageLoad stepKey="waitForCardTypes" time="3"/>
14+
<waitForPageLoad stepKey="waitForCardTypes"/>
1515
<click stepKey="chooseCardType" selector="{{NewOrderSection.masterCard}}"/>
16-
<waitForPageLoad stepKey="waitForCardSelected" time="3"/>
16+
<waitForPageLoad stepKey="waitForCardSelected"/>
1717

1818
<switchToIFrame stepKey="switchToCardNumber" selector="{{NewOrderSection.cardFrame}}"/>
1919
<fillField stepKey="fillCardNumber" selector="{{NewOrderSection.creditCardNumber}}" userInput="{{PaymentAndShippingInfo.cardNumber}}"/>
20-
<waitForPageLoad stepKey="waitForFillCardNumber" time="1"/>
2120
<switchToIFrame stepKey="switchBackFromCard"/>
2221

2322
<switchToIFrame stepKey="switchToExpirationMonth" selector="{{NewOrderSection.monthFrame}}"/>
2423
<fillField stepKey="fillMonth" selector="{{NewOrderSection.expirationMonth}}" userInput="{{PaymentAndShippingInfo.month}}"/>
25-
<waitForPageLoad stepKey="waitForFillMonth" time="1"/>
2624
<switchToIFrame stepKey="switchBackFromMonth"/>
2725

2826
<switchToIFrame stepKey="switchToExpirationYear" selector="{{NewOrderSection.yearFrame}}"/>
2927
<fillField stepKey="fillYear" selector="{{NewOrderSection.expirationYear}}" userInput="{{PaymentAndShippingInfo.year}}"/>
30-
<waitForPageLoad stepKey="waitForFillYear" time="1"/>
3128
<switchToIFrame stepKey="switchBackFromYear"/>
3229

3330
<switchToIFrame stepKey="switchToCVV" selector="{{NewOrderSection.cvvFrame}}"/>
3431
<fillField stepKey="fillCVV" selector="{{NewOrderSection.cvv}}" userInput="{{PaymentAndShippingInfo.cvv}}"/>
35-
<wait stepKey="waitForFillCVV" time="1"/>
3632
<switchToIFrame stepKey="switchBackFromCVV"/>
3733
</actionGroup>
3834
</actionGroups>

0 commit comments

Comments
 (0)