Skip to content

Commit 60e0a69

Browse files
committed
MAGETWO-32367: Move Core\Helper\PostData.php to framework
- Fix docblocks - Call parent constructor in PostHelper - Pix constructor params for ListProduct children
1 parent 0de72f5 commit 60e0a69

File tree

4 files changed

+12
-0
lines changed

4 files changed

+12
-0
lines changed

app/code/Magento/Catalog/Block/Product/ListProduct.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ class ListProduct extends AbstractProduct implements IdentityInterface
6060
* @param \Magento\Framework\Data\Helper\PostHelper $postDataHelper
6161
* @param \Magento\Catalog\Model\Layer\Resolver $layerResolver
6262
* @param CategoryRepositoryInterface $categoryRepository
63+
* @param \Magento\Framework\Url\Helper\Data $urlHelper
6364
* @param array $data
6465
*/
6566
public function __construct(

app/code/Magento/Catalog/Block/Product/ProductList/Promotion.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ class Promotion extends \Magento\Catalog\Block\Product\ListProduct
2828
* @param \Magento\Framework\Data\Helper\PostHelper $postDataHelper
2929
* @param \Magento\Catalog\Model\Layer\Resolver $layerResolver
3030
* @param CategoryRepositoryInterface $categoryRepository
31+
* @param \Magento\Framework\Url\Helper\Data $urlHelper
3132
* @param CollectionFactory $productCollectionFactory
3233
* @param array $data
3334
*/
@@ -36,6 +37,7 @@ public function __construct(
3637
\Magento\Framework\Data\Helper\PostHelper $postDataHelper,
3738
\Magento\Catalog\Model\Layer\Resolver $layerResolver,
3839
CategoryRepositoryInterface $categoryRepository,
40+
\Magento\Framework\Url\Helper\Data $urlHelper,
3941
CollectionFactory $productCollectionFactory,
4042
array $data = []
4143
) {
@@ -45,6 +47,7 @@ public function __construct(
4547
$postDataHelper,
4648
$layerResolver,
4749
$categoryRepository,
50+
$urlHelper,
4851
$data
4952
);
5053
}

app/code/Magento/Catalog/Block/Product/ProductList/Random.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ class Random extends \Magento\Catalog\Block\Product\ListProduct
3131
* @param \Magento\Framework\Data\Helper\PostHelper $postDataHelper
3232
* @param \Magento\Catalog\Model\Layer\Resolver $layerResolver
3333
* @param CategoryRepositoryInterface $categoryRepository
34+
* @param \Magento\Framework\Url\Helper\Data $urlHelper
3435
* @param \Magento\Catalog\Model\Resource\Product\CollectionFactory $productCollectionFactory
3536
* @param array $data
3637
*/
@@ -39,6 +40,7 @@ public function __construct(
3940
\Magento\Framework\Data\Helper\PostHelper $postDataHelper,
4041
\Magento\Catalog\Model\Layer\Resolver $layerResolver,
4142
CategoryRepositoryInterface $categoryRepository,
43+
\Magento\Framework\Url\Helper\Data $urlHelper,
4244
\Magento\Catalog\Model\Resource\Product\CollectionFactory $productCollectionFactory,
4345
array $data = []
4446
) {
@@ -48,6 +50,7 @@ public function __construct(
4850
$postDataHelper,
4951
$layerResolver,
5052
$categoryRepository,
53+
$urlHelper,
5154
$data
5255
);
5356
}

lib/internal/Magento/Framework/Data/Helper/PostHelper.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,15 @@ class PostHelper extends \Magento\Framework\App\Helper\AbstractHelper
1919
*/
2020
private $urlHelper;
2121

22+
/**
23+
* @param Context $context
24+
* @param UrlHelper $urlHelper
25+
*/
2226
public function __construct(
2327
Context $context,
2428
UrlHelper $urlHelper
2529
) {
30+
parent::__construct($context);
2631
$this->urlHelper = $urlHelper;
2732
}
2833

0 commit comments

Comments
 (0)