MAGETWO-65199: [GitHub][PR] [PSR-2 Compliance] Fix #8612: Hundreds of PHPCS-based static tests violations in mainline #8685

 - fixed code style issues

Author: Oleksii Korshenko

app/code/Magento/Backend/Model/View/Layout/Reader/Block.php

@@ -14,11 +14,13 @@
 class Block extends Layout\Reader\Block
 {
     /**
+     * Initialize dependencies.
+     *
      * @param Layout\ScheduledStructure\Helper $helper
      * @param Layout\Argument\Parser $argumentParser
      * @param Layout\ReaderPool $readerPool
      * @param InterpreterInterface $argumentInterpreter
-     * @param null $scopeType
+     * @param string|null $scopeType
      */
     public function __construct(
         Layout\ScheduledStructure\Helper $helper,

app/code/Magento/Braintree/Block/Customer/PayPal/VaultTokenRenderer.php

@@ -22,6 +22,8 @@ class VaultTokenRenderer extends AbstractTokenRenderer
     private $config;
 
     /**
+     * Initialize dependencies.
+     *
      * @param Template\Context $context
      * @param Config $config
      * @param array $data

app/code/Magento/Braintree/Gateway/Config/PayPal/Config.php

@@ -36,6 +36,8 @@ class Config extends \Magento\Payment\Gateway\Config\Config
     private $icon = [];
 
     /**
+     * Initialize dependencies.
+     *
      * @param ScopeConfigInterface $scopeConfig
      * @param CcConfig $ccConfig
      * @param null $methodCode

app/code/Magento/Braintree/Model/Ui/PayPal/ConfigProvider.php

@@ -29,6 +29,8 @@ class ConfigProvider implements ConfigProviderInterface
     private $resolver;
 
     /**
+     * Initialize dependencies.
+     *
      * @param Config $config
      * @param ResolverInterface $resolver
      */
@@ -39,6 +41,8 @@ public function __construct(Config $config, ResolverInterface $resolver)
     }
 
     /**
+     * Retrieve assoc array of checkout configuration
+     *
      * @return array
      */
     public function getConfig()

app/code/Magento/Customer/Model/Plugin/CustomerNotification.php

@@ -37,6 +37,8 @@ class CustomerNotification
     private $state;
 
     /**
+     * Initialize dependencies.
+     *
      * @param Session $session
      * @param NotificationStorage $notificationStorage
      * @param State $state

app/code/Magento/Quote/Observer/Frontend/Quote/Address/CollectTotalsObserver.php

@@ -47,6 +47,8 @@ class CollectTotalsObserver implements ObserverInterface
     protected $groupManagement;
 
     /**
+     * Initialize dependencies.
+     *
      * @param \Magento\Customer\Helper\Address $customerAddressHelper
      * @param \Magento\Customer\Model\Vat $customerVat
      * @param VatValidator $vatValidator

app/code/Magento/Review/Block/Adminhtml/Rating/Edit/Tab/Form.php

@@ -243,6 +243,7 @@ protected function initFieldset($formId, array $config)
             if (!$this->getForm()->getElement($formId)) {
                 $this->fieldset[$formId] = $this->getForm()->addFieldset($formId, $config);
             } elseif ($this->getForm()->getElement($formId)) {
+                //do nothing
             }
         }
     }

dev/tests/static/framework/Magento/TestFramework/Dependency/DiRule.php

@@ -141,7 +141,7 @@ private function getHardDependencies(DOMDocument $doc)
         $result = [];
         $xpath = new DOMXPath($doc);
         $textNodes = $xpath->query('//*[@xsi:type="object"]');
-/** @var \DOMElement $node */
+        /** @var \DOMElement $node */
         foreach ($textNodes as $node) {
             $result[] = $node->nodeValue;
         }

pub/errors/processor.php

@@ -329,10 +329,10 @@ protected function _prepareConfig()
         $config->skin           = self::DEFAULT_SKIN;
 
         //combine xml data to one object
-        if ($design === null && (string)$design->skin) {
+        if ($design !== null && (string)$design->skin) {
             $this->_setSkin((string)$design->skin, $config);
         }
-        if ($local === null) {
+        if ($local !== null) {
             if ((string)$local->report->action) {
                 $config->action = $local->report->action;
             }